Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy paste last value pasting a promise #26

Merged
merged 3 commits into from
Jun 21, 2024
Merged

fix: copy paste last value pasting a promise #26

merged 3 commits into from
Jun 21, 2024

Conversation

gokulk16
Copy link
Owner

@gokulk16 gokulk16 commented Jun 21, 2024

Changes:

  • Removing the it and using test to be consistent in the unit tests
  • Fix for the bug where the Promise object is printed instead of pasting the last numeric value
  • Added unit tests for the above fix and its relevant methods
  • round of copied values using keyboard shortcuts

Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for typetocalculate ready!

Name Link
🔨 Latest commit 464d328
🔍 Latest deploy log https://app.netlify.com/sites/typetocalculate/deploys/667525a27256170008d3a196
😎 Deploy Preview https://deploy-preview-26--typetocalculate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jun 21, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 64.33%
⬆️ +0.67%
691 / 1074
🔵 Statements 64.33%
⬆️ +0.67%
691 / 1074
🔵 Functions 64.06%
⬆️ +2.16%
41 / 64
🔵 Branches 75.19%
⬆️ +0.59%
97 / 129
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
js/editor.js 58.86% 78.16% 59.18% 58.86% 38, 41-42, 48-54, 56-59, 73-78, 86-90, 120-123, 129-130, 161-162, 192-196, 199-208, 210-250, 252-279, 281-287, 290-315, 321-325, 330-331, 334-343, 387-390, 414, 425-430, 443-445, 452-482, 503-504, 537-553, 590-591, 617-621, 623-628, 630-634, 654-656, 658-682, 696-697, 700-704, 706-717, 719-726, 728-730, 732-738, 740-743
Generated in workflow #35

@gokulk16 gokulk16 merged commit 58d7167 into main Jun 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant