Skip to content

Commit

Permalink
docs: fix comment in KeyFunc
Browse files Browse the repository at this point in the history
  • Loading branch information
@mfridman
mfridman committed Sep 13, 2023
1 parent c80de55 commit 0cb4fa1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion token.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
// Token. This allows you to use properties in the Header of the token (such as
// `kid`) to identify which key to use.
//
// The returned interface{} may be a single key or a PublicKeyset containing
// The returned interface{} may be a single key or a VerificationKeySet containing
// multiple keys.
type Keyfunc func(*Token) (interface{}, error)

Expand Down

3 comments on commit 0cb4fa1

@oxisto
Copy link
Collaborator

@oxisto oxisto commented on 0cb4fa1 Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, looks like I didn't do a proper review on this one ;)

@mfridman
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be misremembering, I thought for docs we were okay with committing directly to main. For tests/examples a single review was okay, and for anything that touches the core of this library we always thoroughly review and have at least 2 people sign off?

No strong opinion, I can open a PR next time.

@oxisto
Copy link
Collaborator

@oxisto oxisto commented on 0cb4fa1 Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries :) I just meant that I should have caught that mistake in the original PR 🤩

Please sign in to comment.