chore: replace ioutil with io and os #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfridman
reviewed
May 2, 2022
| @@ -1,10 +1,11 @@ | |||
| //go:build go1.4 | |||
There was a problem hiding this comment.
Do we still need these build tags? Can we remove them entirely..
There was a problem hiding this comment.
I think that's out of scope for this PR, but I'm happy to create another PR removing them. This build line is added because Go 1.17 has a new syntax for them.
mfridman
reviewed
May 2, 2022
mfridman
approved these changes
May 6, 2022
|
cc @golang-jwt/maintainers what are your thoughts? |
Fine by me. |
oxisto
approved these changes
May 27, 2022
oxisto
pushed a commit
to moneszarrugh/jwt
that referenced
this pull request
Feb 21, 2023
oxisto
added a commit
to twocs/jwt
that referenced
this pull request
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ioutilwas deprecated in Go 1.16