-
Notifications
You must be signed in to change notification settings - Fork 158
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
main.star: rewrite regexp for files related to vendored code
We have a recent data point showing the regexp added in CL 547596 isn't working as intended: no longtest builder was started in CL 593684 even though it modified vendored files. I suspect the problem was that {path1,path2} is pseudo-syntax we use in Go issue titles and such, but it's not a valid regexp pattern. Use one with a capturing group like (path1|path2) instead. Also generalize the pattern such that it works even if there is a new module, something other than cmd or std. Such changes are rare enough that we'd want a longtest builder to always run. Do the same for ssacheck while here. For golang/go#42661. Change-Id: I6d52193bbbd46e4e4a990356a01261f63338e5f7 Reviewed-on: https://go-review.googlesource.com/c/build/+/594615 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Knyszek <mknyszek@google.com>
- Loading branch information
Showing
2 changed files
with
17 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters