Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Commit

Permalink
Update exists (pre-PR) tests to pass
Browse files Browse the repository at this point in the history
One test relied upon constraints NOT being applied transitively. The
other was named incorrectly, it was testing a non-root scenario but was
named "transitive" which was misleading.
  • Loading branch information
carolynvs committed Dec 28, 2017
1 parent 16689ce commit 41150b2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions gps/solve_bimodal_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -188,12 +188,12 @@ var bimodalFixtures = map[string]bimodalFixture{
},
r: mksolution(
"a 1.0.0",
"b 1.1.0",
"b 1.0.0", // Now that constraints can be applied transitively, the constraint from root applies
),
},
// Constraints apply only if the project that declares them has a
// reachable import - non-root
"constraints activated by import, transitive": {
"constraints activated by import, non-root": {
ds: []depspec{
dsp(mkDepspec("root 0.0.0"),
pkg("root", "root/foo", "b"),
Expand Down

0 comments on commit 41150b2

Please sign in to comment.