Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Commit

Permalink
Remove some old TODOs that no longer apply
Browse files Browse the repository at this point in the history
  • Loading branch information
sdboyer committed Jul 25, 2017
1 parent 0a63c47 commit 6a17782
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 8 deletions.
3 changes: 1 addition & 2 deletions analyzer.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ func (a Analyzer) DeriveManifestAndLock(path string, n gps.ProjectRoot) (gps.Man
if err != nil {
return nil, nil, err
}
// TODO: No need to return lock til we decide about preferred versions, see
// https://github.com/sdboyer/gps/wiki/gps-for-Implementors#preferred-versions.

return m, nil, nil
}

Expand Down
2 changes: 0 additions & 2 deletions internal/gps/bridge.go
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,6 @@ func (b *bridge) breakLock() {

for _, lp := range b.s.rd.rl.Projects() {
if _, is := b.s.sel.selected(lp.pi); !is {
// TODO(sdboyer) use this as an opportunity to detect
// inconsistencies between upstream and the lock (e.g., moved tags)?
pi, v := lp.pi, lp.Version()
go func() {
// Sync first
Expand Down
3 changes: 0 additions & 3 deletions internal/gps/constraint_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,6 @@ func TestBranchConstraintOps(t *testing.T) {
}

// Now add same rev to different branches
// TODO(sdboyer) this might not actually be a good idea, when you consider the
// semantics of floating versions...matching on an underlying rev might be
// nice in the short term, but it's probably shit most of the time
v5 := v2.Pair(Revision("snuffleupagus")).(versionPair)
if !v5.Matches(v3) {
t.Errorf("%s should match %s", gu(v5), gu(v3))
Expand Down
1 change: 0 additions & 1 deletion internal/gps/result.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ func WriteDepTree(basedir string, l Lock, sm SourceManager, sv bool) error {
if sv {
filepath.Walk(to, stripVendor)
}
// TODO(sdboyer) dump version metadata file
}

return nil
Expand Down

0 comments on commit 6a17782

Please sign in to comment.