Adding UX output to dep init

golang · Sep 17, 2017 · fe2e56f · fe2e56f
1 parent d62440d
commit fe2e56f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/cmd/dep/init.go b/cmd/dep/init.go
@@ -136,7 +136,7 @@ func (cmd *initCommand) Run(ctx *dep.Ctx, args []string) error {
 	if ctx.Verbose {
 		ctx.Out.Println("Getting direct dependencies...")
 	}
-	pkgT, directDeps, err := getDirectDependencies(sm, p)
+	pkgT, directDeps, err := getDirectDependencies(sm, p, ctx)
 	if err != nil {
 		return err
 	}
@@ -226,7 +226,7 @@ func (cmd *initCommand) Run(ctx *dep.Ctx, args []string) error {
 	return nil
 }
 
-func getDirectDependencies(sm gps.SourceManager, p *dep.Project) (pkgtree.PackageTree, map[string]bool, error) {
+func getDirectDependencies(sm gps.SourceManager, p *dep.Project, ctx *dep.Ctx) (pkgtree.PackageTree, map[string]bool, error) {
 	pkgT, err := pkgtree.ListPackages(p.ResolvedAbsRoot, string(p.ImportRoot))
 	if err != nil {
 		return pkgtree.PackageTree{}, nil, errors.Wrap(err, "gps.ListPackages")
@@ -239,6 +239,9 @@ func getDirectDependencies(sm gps.SourceManager, p *dep.Project) (pkgtree.Packag
 		if err != nil {
 			return pkgtree.PackageTree{}, nil, err
 		}
+		if !directDeps[string(pr)] {
+			ctx.Out.Printf("Cached %s ", string(pr))
+		}
 		directDeps[string(pr)] = true
 	}
 

diff --git a/cmd/dep/init_test.go b/cmd/dep/init_test.go
@@ -30,7 +30,7 @@ func TestGetDirectDependencies_ConsolidatesRootProjects(t *testing.T) {
 	testpath := h.Path(testdir)
 	prj := &dep.Project{AbsRoot: testpath, ResolvedAbsRoot: testpath, ImportRoot: gps.ProjectRoot(testprj)}
 
-	_, dd, err := getDirectDependencies(sm, prj)
+	_, dd, err := getDirectDependencies(sm, prj, NewTestContext(h))
 	h.Must(err)
 
 	wantpr := "github.com/carolynvs/deptest-subpkg"