Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Report more about what init is doing #185

Closed
sdboyer opened this issue Jan 28, 2017 · 4 comments
Closed

Report more about what init is doing #185

sdboyer opened this issue Jan 28, 2017 · 4 comments

Comments

@sdboyer
Copy link
Member

sdboyer commented Jan 28, 2017

From @peterbourgon in #131 (comment):

I think we need to have init print out what it's doing, even at a coarse level ("cloning foo/bar/baz") and even without -v.

It'd be great to have someone go through and weave in some of this additional output. If anyone's interested, please feel free to ask questions here, or over in the gopher slack!

@xmattstrongx
Copy link
Contributor

Id like to help out with this one. Just cloned the repo so grocking the code now.

@xmattstrongx
Copy link
Contributor

xmattstrongx commented Jan 28, 2017

Ok. I get the flow of init. I quickly wrote some basic logic to range through all the Manifest dependencies after a successful call to sw.WriteAllSafe and print out Cloning: github.com/hulk-hogan/legdrop for each.

Cloning: github.com/emicklei/go-restful
Cloning: github.com/go-kit/kit
Cloning: gopkg.in/mgutz/dat.v1
Cloning: github.com/stretchr/testify

Currently this is happening regardless of wether the -v flag is passed or not.

Not sure if this is exactly what is being looked for with this issue. Id love some feedback so I can continue to move forward with this.

@sdboyer
Copy link
Member Author

sdboyer commented Jan 29, 2017

@xmattstrongx from that description, it sounds like it's not quite what we're looking for with this - it'll probably be printing after all the time-consuming work is already done. But put up what you have as a PR, and we can take a more in-depth look.

@sdboyer
Copy link
Member Author

sdboyer commented Jan 31, 2017

I think we can call this closed now; can make a new one if specific new changes are needed.

@sdboyer sdboyer closed this as completed Jan 31, 2017
krisnova pushed a commit to krisnova/dep that referenced this issue Apr 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants