Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Github path validation is too aggressive #354

Closed
nathanielc opened this issue Mar 28, 2017 · 4 comments · Fixed by #361
Closed

Github path validation is too aggressive #354

nathanielc opened this issue Mar 28, 2017 · 4 comments · Fixed by #361
Labels

Comments

@nathanielc
Copy link
Contributor

While trying to vendor a the dependency github.com/hashicorp/memberlist a secondary dep of github.com/sean-/seed was introduced but dep refused to download that version printing the error:

master: github.com/sean-/seed is not a valid path for a source on github.com
@nathanielc
Copy link
Contributor Author

nathanielc commented Mar 28, 2017

After looking into fixing this it turns out that it has already been fixed in upstream in the https://github.com/sdboyer/gps repo. Updating that dependency should fix this issue.

@paddie
Copy link

paddie commented Mar 28, 2017

So, should this issue be closed?

@nathanielc
Copy link
Contributor Author

nathanielc commented Mar 28, 2017 via email

@sdboyer sdboyer added the bug label Mar 29, 2017
@sdboyer
Copy link
Member

sdboyer commented Mar 29, 2017

Thanks for the report! And yep, it's fixed upstream.

We're currently trying to move gps directly into dep - #300 - but if that continues to drag on, I may just update the dependency.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants