Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

status output is no longer in table form #532

Closed
darkowlzz opened this issue May 9, 2017 · 2 comments
Closed

status output is no longer in table form #532

darkowlzz opened this issue May 9, 2017 · 2 comments

Comments

@darkowlzz
Copy link
Collaborator

darkowlzz commented May 9, 2017

$ go version
go version go1.8 darwin/amd64

Operating System: macOS 10.12.4
Processor Architecture: x86_64

Expected result:

PROJECT                        CONSTRAINT     VERSION        REVISION  LATEST   PKGS USED
github.com/darkowlzz/openurl   branch master  branch master  673a04d   673a04d  1
github.com/fsnotify/fsnotify   branch master  branch master  4da3e2c   4da3e2c  1
github.com/sdboyer/deptest     *              v1.0.0         ff2948a   ff2948a  1
github.com/sdboyer/deptestdos  ^2.0.0         v2.0.0         5c60720   5c60720  1
golang.org/x/sys               *              branch master  9ccfe84   9ccfe84  1

Received result:

PROJECT



CONSTRAINT

VERSION

REVISION

LATEST

PKGS USED

github.com/darkowlzz/openurl

branch master

branch master

673a04d

673a04d

1

...
@jmank88
Copy link
Collaborator

jmank88 commented May 9, 2017

This looks like the logWriter I introduced in #525. Something to do with the tabwriter passing raw []byte->string->interface{} argument. I cloned it off of the gps testlogger, which only writes to testing.Log, and may dodge the issue.

Working on a fix.

@jmank88
Copy link
Collaborator

jmank88 commented May 9, 2017

Every time the tabwriter writes through to the log.Logger, a newline is appended if one is not present 👎

Unfortunately, I think that log.Logger fundamentally cannot be adapted as an io.Writer in the general case because of this. I'm not sure what the best solution is. The simplest would be to buffer and print once to the log.

sdboyer added a commit that referenced this issue May 11, 2017
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants