Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

fix(manifest): validate project roots in manifest #1116

Merged
merged 5 commits into from
Sep 10, 2017
Merged

fix(manifest): validate project roots in manifest #1116

merged 5 commits into from
Sep 10, 2017
+166 −4

Commits on Sep 9, 2017

  1. fix(manifest): validate project roots in manifest 

    Validating ProjectRoot(s) require source manager, which is created after
loading the project. Hence, ProjectRoot validation can't be done in
existing validateManifest.

This change adds `ValidateProjectRoots()` which validates only the Constraint
and Override names to be valid ProjectRoot. Warnings are issued at stderr when
invalid ProjectRoot is found in manifest.

`ensure` and `status` call `ValidateProjectRoots()` expecitly.
    @darkowlzz
    darkowlzz committed Sep 9, 2017
    Configuration menu
    Copy the full SHA
    7a32e01 View commit details
    Browse the repository at this point in the history

  2. change ProjectRoot Validation warning message

    @darkowlzz
    darkowlzz committed Sep 9, 2017
    Configuration menu
    Copy the full SHA
    ee6e7ad View commit details
    Browse the repository at this point in the history

  3. manifest: make ValidateProjectRoots concurrent

    @darkowlzz
    darkowlzz committed Sep 9, 2017
    Configuration menu
    Copy the full SHA
    0e4d48c View commit details
    Browse the repository at this point in the history

  4. manifest: move validate goroutine in var and reuse

    @darkowlzz
    darkowlzz committed Sep 9, 2017
    Configuration menu
    Copy the full SHA
    c0d23a6 View commit details
    Browse the repository at this point in the history

  5. manifest: fix typos

    @darkowlzz
    darkowlzz committed Sep 9, 2017
    Configuration menu
    Copy the full SHA
    fa811f2 View commit details
    Browse the repository at this point in the history