This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
gps: ./hack/lint.bash fixes #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we just added the prune funcs - I don't know why the linters are complaining about unused exported funcs (also, wait what, I thought we had tests for those funcs), but we need to keep those. if we have failures, we need to add exceptions for them to the linters, not remove the code |
|
the other change is 👍 though |
Because they are internal? |
|
linters generally only take the current package scope into context, since they operate on a per package basis. so, maybe? but it wouldn't be my first guess
…On September 24, 2017 9:03:35 AM EDT, Jordan Krage ***@***.***> wrote:
> I don't know why the linters are complaining about unused exported
funcs
Because they are internal?
--
You are receiving this because your review was requested.
Reply to this email directly or view it on GitHub:
#1217 (comment)
|
I knew something was missing... 🤦♂️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This PR fixes
./hack/lint.bashfailures, by directly returning errors andremovingignoring unused functions/types fromprune.go.Do you need help or clarification on anything?
Should the errors be wrapped?