Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

pkgtree: add os.IsPermission check for walkFn err arg #1221

Merged
merged 1 commit into from
Sep 26, 2017
Merged

pkgtree: add os.IsPermission check for walkFn err arg #1221

merged 1 commit into from
Sep 26, 2017

Conversation

jmank88
Copy link
Collaborator

@jmank88 jmank88 commented Sep 26, 2017

What does this do / why do we need it?

This PR adds a check for the incoming err argument of this walkFn, in response to a recent change on tip.

Which issue(s) does this PR fix?

Fixes #1220

Copy link
Member

@sdboyer sdboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kinda obnoxious that we now have to have the os.IsPermission() check in multiple places 😢

let's included some comments on this, and the call to it later down, in order to clarify why the check appears twice.

@jmank88
Copy link
Collaborator Author

jmank88 commented Sep 26, 2017

What did you have in mind? I can qualify the old comment as only applying to <=1.9, but the new code at the top seems self explanatory.

Copy link
Member

@sdboyer sdboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh, i literally didn't notice that we already had a detailed comment written there 😛

but the versioned addition to it is 👍

@sdboyer sdboyer merged commit 0979f44 into golang:master Sep 26, 2017
@jmank88 jmank88 deleted the pkgtree-ls-pkg branch September 26, 2017 11:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkgtree: TestListPackagesNoPerms failing with Go tip
3 participants