fix(status): check lockfile before runStatusAll() #1238
Conversation
There was a problem hiding this comment.
LGTM
Isn't this missing check another separate problem affecting #1232?
|
@jmank88 err... I think that link is pointing to code that has changed recently 😅 Can you check if there's still a problem? |
|
oh! I see an issue, maybe the same issue you're referring, even in the new code. The error is received but never logged but |
cmd/dep/status.go
Outdated
| ctx.Err.Println(err) | ||
| } else { | ||
| ctx.Out.Println("Failed to get status. Rerun with `-v` flag to see details.") | ||
| } |
There was a problem hiding this comment.
I was only thinking "don't suggest -v when it's already present". Isn't the same err already returned and logged higher up somewhere?
There was a problem hiding this comment.
oops! you're right, I overlooked that 😅 So, we get rid of the default part and there's no need to move the lock check. But moving the check up there doesn't harm in anyway. Let's keep it up there.
darkowlzz
force-pushed
the
1232-status-lockfile-check
branch
from
1d594fe
to
365e4ee
Compare
What does this do / why do we need it?
Moves lockfile check before
runStatusAll().What should your reviewer look out for in this PR?
¯_(ツ)_/¯
Do you need help or clarification on anything?
No.
Which issue(s) does this PR fix?
fixes #1232