gps: skip hidden directories when looking for packages

[vincentbernat]

Stuff in hidden directories should stay hidden. In my case, I am using a special GOPATH and I don't want dep to look into it.

[sdboyer]

sorry, this can't be how this works. it is valid, even if inadvisable, to import packages under dot dirs, and ListPackages has to model all possibly-valid importable locations when creating its virtual representation of the filesystem.

[vincentbernat]

go list also skips hidden directories. Moreover, by the same logic, VCS directories and Godeps shouldn't be skipped. Please, reconsider.

[sdboyer]

this decision has already undergone dozens of hours of consideration, and was not arrived at lightly. it is not the same domain as `go list`, and the same rules should not apply. to reiterate: making this change would be equivalent to banning all import paths containing dot dirs. the compiler considers those valid, and we must as well - that is the domain we are in, not `go list`. we cannot visit vendor or Godeps dirs because they are known to contain dependency code, and are thus out of scope for consideration. We exclude VCS dirs because there is no sane way in which go code contained in such dirs could be a part of a redistributable project. all of these are domain-specific considerations in a way that is not comparable to dot dirs. there is a possible approach with the same outcome as this patch in >99.99% of cases, where we could conditionally avoid descending into dot dirs. it does add some complexity, as we have to adaptively determine from the import set in non-dot/underscore-led dirs whether or not it's needed to actually explore those, then restart work if we determine that it is. that's the only way this class of change could be accepted, and it hasn't really been necessary so far - but, if you're hiding an entire GOPATH under a dot dir, though, I can see it being worthwhile to skip that analysis 😀

…

On October 10, 2017 7:41:28 AM EDT, Vincent Bernat ***@***.***> wrote: `go list` also skips hidden directories. Moreover, by the same logic, VCS directories and `Godeps` shouldn't be skipped. Please, reconsider. -- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: #1251 (comment)

[vincentbernat]

In fact, the additional analysis doesn't bother me much but starting from 242e387 and 19c7f60, pkgtree will recurse into dep itself and choke on invalid tests and I get this kind of error:

ensure ListPackage for project: import path hellogopher/.gopath~/src/github.com/golang/dep/internal/gps/_testdata/src/canon_confl had conflicting import comments: "vanity1", "vanity2"

[vincentbernat]

For context, I am doing stuff like that to get a local GOPATH: https://github.com/vincentbernat/hellogopher/blob/master/Makefile#L26.

This is not something totally alien as some popular developers advertise this way of doing things (well, at least one): https://github.com/cloudflare/hellogopher/blob/master/Makefile.

[sdboyer]

uuuugghh.

yeah, we keep ping-ponging around on these individual package-level errors, as well as what we should be looking at at all (within the root project). this whole model needs improving.

#1253 will be where this can live on, as @darkowlzz is gonna take on making the necessary deeper improvements.