Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Move bad go code under a vendor/ subdirectory. #1253

Closed
wants to merge 1 commit into from
Closed

Move bad go code under a vendor/ subdirectory. #1253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/gps/_testdata/src/canon_confl/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
The packages inside `vendor/` directoy contain bad go code. This "vendor"
directory exists to avoid its content from being parsed by ListPackages when
running on the whole dep code base.
0 internal/gps/_testdata/src/canon_confl/a.go → ...a/src/canon_confl/vendor/canon_confl/a.go
View file
Open in desktop
File renamed without changes.
0 internal/gps/_testdata/src/canon_confl/b.go → ...a/src/canon_confl/vendor/canon_confl/b.go
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion internal/gps/pkgtree/pkgtree_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1315,7 +1315,7 @@ func TestListPackages(t *testing.T) {
},
},
"conflicting canonical comments": {
fileRoot: j("canon_confl"),
fileRoot: j("canon_confl", "vendor", "canon_confl"),
importRoot: "canon_confl",
out: PackageTree{},
err: &ConflictingImportComments{
Expand Down