This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
Trim hidden packages from (root) PackageTrees #1271
Merged
Merged
Commits on Oct 14, 2017
-
pkgtree: add TrimHiddenPackages() method
This has general utility, independent of ListPackages() being improved to avoid unnecessary disk reads in typically-hidden directories.
Configuration menu - View commit details
-
Copy full SHA for ce78a47 - Browse repository at this point
Copy the full SHA ce78a47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89bd85d - Browse repository at this point
Copy the full SHA 89bd85dView commit details -
dep: Use TrimHiddenPackages in a standard way
This consolidates calls to parse the root project's code tree into a single place, so as to avoid confusion about the standard, expected way that dep's root project tree is to be created. It may not be fully suitable for all status cases, but standardization is crucial for init and ensure.
Configuration menu - View commit details
-
Copy full SHA for 8e423e6 - Browse repository at this point
Copy the full SHA 8e423e6View commit details -
gps: Demote import comment conflicts to pkg-level
These should never have been global failures within ListPackages(), as they are entirely package-specific information.
Configuration menu - View commit details
-
Copy full SHA for c1d177d - Browse repository at this point
Copy the full SHA c1d177dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b962643 - Browse repository at this point
Copy the full SHA b962643View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09ee5b7 - Browse repository at this point
Copy the full SHA 09ee5b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0951d5d - Browse repository at this point
Copy the full SHA 0951d5dView commit details
Commits on Oct 15, 2017
-
gps: Make PackageTree.Copy more careful, efficient
We only perform a single allocation for all []string, and are careful to copy all possible error values via reflection.
Configuration menu - View commit details
-
Copy full SHA for b672a99 - Browse repository at this point
Copy the full SHA b672a99View commit details -
gps: Remove keepIgnored from TrimHiddenPackages
While this would be possible to implement, it would require writing entirely new entry logic into wmToReach(). That seems like a sufficiently strong indication of breaking domain assumptions that it's preferable just to drop the parameter, which was questionable in the first place.
Configuration menu - View commit details
-
Copy full SHA for adedbf9 - Browse repository at this point
Copy the full SHA adedbf9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4909ed - Browse repository at this point
Copy the full SHA e4909edView commit details -
Configuration menu - View commit details
-
Copy full SHA for ecd7b87 - Browse repository at this point
Copy the full SHA ecd7b87View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.