Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Trim hidden packages from (root) PackageTrees #1271

Merged
merged 11 commits into from
Oct 15, 2017

Commits on Oct 14, 2017

  1. pkgtree: add TrimHiddenPackages() method

    This has general utility, independent of ListPackages() being improved
    to avoid unnecessary disk reads in typically-hidden directories.
    sdboyer committed Oct 14, 2017
    Configuration menu
    Copy the full SHA
    ce78a47 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    89bd85d View commit details
    Browse the repository at this point in the history
  3. dep: Use TrimHiddenPackages in a standard way

    This consolidates calls to parse the root project's code tree into a
    single place, so as to avoid confusion about the standard, expected way
    that dep's root project tree is to be created. It may not be fully
    suitable for all status cases, but standardization is crucial for init
    and ensure.
    sdboyer committed Oct 14, 2017
    Configuration menu
    Copy the full SHA
    8e423e6 View commit details
    Browse the repository at this point in the history
  4. gps: Demote import comment conflicts to pkg-level

    These should never have been global failures within ListPackages(), as
    they are entirely package-specific information.
    sdboyer committed Oct 14, 2017
    Configuration menu
    Copy the full SHA
    c1d177d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b962643 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    09ee5b7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0951d5d View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2017

  1. gps: Make PackageTree.Copy more careful, efficient

    We only perform a single allocation for all []string, and are careful to
    copy all possible error values via reflection.
    sdboyer committed Oct 15, 2017
    Configuration menu
    Copy the full SHA
    b672a99 View commit details
    Browse the repository at this point in the history
  2. gps: Remove keepIgnored from TrimHiddenPackages

    While this would be possible to implement, it would require writing
    entirely new entry logic into wmToReach(). That seems like a
    sufficiently strong indication of breaking domain assumptions that it's
    preferable just to drop the parameter, which was questionable in
    the first place.
    sdboyer committed Oct 15, 2017
    Configuration menu
    Copy the full SHA
    adedbf9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e4909ed View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ecd7b87 View commit details
    Browse the repository at this point in the history