This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
dep: Use hidden tempdir for old vendor #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While there's more work to be done in making all of this safe in the event of a signal being sent to dep, this change at least means that if a signal is sent during the rename and a .vendor.orig directory is left behind, subsequent runs will treat its contents as ignored. Fixes golang#1304
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
If the txn writer leaves a
vendor.origdirectory behind, subsequent runs will barf on it - #1304.While there's more work to be done in making all of this safe in the event of a signal being sent to dep, this change at least means that if a signal is sent during the rename and a .vendor.orig directory is left behind, subsequent runs will treat its contents as ignored.
What should your reviewer look out for in this PR?
Do you need help or clarification on anything?
Which issue(s) does this PR fix?
Fixes #1304