Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

update FAQ CI usage section for caching caveats #1359

Merged
merged 1 commit into from
Nov 12, 2017

Conversation

sudo-suhas
Copy link
Contributor

@sudo-suhas sudo-suhas commented Nov 9, 2017

What does this do / why do we need it?

This updates the FAQ section for dep usage in CI for caching. It mentions the caveats as noted by @carolynvs in #1293 (comment) and the travis config snippet for enabling it.

What should your reviewer look out for in this PR?

Is there any change required in the wording?

Do you need help or clarification on anything?

Are there any other caveats that are worth mentioning?

Which issue(s) does this PR fix?

None.

Preview link - sudo-suhas/dep:docs/FAQ.md@docs-faq-ci-caching#how-do-i-use-dep-in-ci

@carolynvs
Copy link
Collaborator

Have you used this on Travis yet? I'd like to see what it looks like, and then (since this is just quoting the great and powerful carolynvs) I'm cool with merging. 😀

@sudo-suhas
Copy link
Contributor Author

Have you used this on Travis yet?

Same as last time - https://travis-ci.org/sudo-suhas/symcrypto. If nothing else, this repo was great for me to learn and try out a few things related to Go packages.

I'd like to see what it looks like, and then (since this is just quoting the great and powerful carolynvs) I'm cool with merging. 😀

Ha ha.. yea.. I am fairly sure I can't do any better than your explanation. It was pretty succinct.

@carolynvs
Copy link
Collaborator

Doh! 😊 Yes, I saw that last time and totally brain farted...

Thanks for explaining how to use dep with Travis! 👍

@carolynvs carolynvs merged commit a5f10f1 into golang:master Nov 12, 2017
@sudo-suhas sudo-suhas deleted the docs-faq-ci-caching branch November 12, 2017 04:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants