Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

[WIP] Prototype doc site #1369

Closed
wants to merge 1 commit into from
Closed

[WIP] Prototype doc site #1369

wants to merge 1 commit into from

Conversation

carolynvs
Copy link
Collaborator

@carolynvs carolynvs commented Nov 12, 2017

What does this do / why do we need it?

This is a prototype for a dep doc site. You can see an example of it at https://carolynvs.github.io/depdocs/.

  • It uses Hugo as the static site generator.
  • The docs source continue to be located in /docs, and are versioned along with the dep code.
  • The site is hosted on github pages and the generated files are in the gh-pages branch. This branch should never be manually tweaked as changes will be lost on the next push.
  • The site would be located at https://golang.github.io/dep/.
  • Travis is configured to generate the site for pushes to master, and for tagged releases.
  • Tagged releases are published to /releases/vX.Y.Z/. The sidebar links to these manually (but an enterprising person would be welcome to automate this part).
  • We will not go back and update older releases doc. Whatever was present when we tagged, is what is included.
  • There is an encrypted deploy key checked into hack which travis uses to push to gh-pages. PR builds do not have access to this, it's only decrypted for merged code.
  • The modified/forked theme is located at https://github.com/carolynvs/hugo-alabaster-theme/tree/depdocs. I am exporting it and checking it into our repo so that we don't mess with submodules or anything fussy.

Before we merge this the following should occur. I'll do this on this PR after we are sure we want to accept this PR:

  • Remove the old standalone doc files and move the content into the generated site.
  • Update all links
  • Remove duplicate content from the readme and link to the site. We'll keep dev specific sections like contributing/feedback, but usage, etc should not be duplicated.
  • Document how to preview the site locally (here's the makefile I am using in the example site)
  • Add the deploy key to this repo.

What should your reviewer look out for in this PR?

  • Is this a workable initial setup for our doc site?

What is not in scope?

  • It doesn't have to be a drop in / migration ready setup for when dep is merged into the toolchain.
  • I don't have any frontend aspirations and would like to avoid any changes to the theme or visuals. Hopefully we can find someone with more design skills to tackle and incrementally improve the site.
  • I'm explicitly not adding new content or majorly reorganizing it. Once we have the infrastructure in place, we can tweak from there.

Do you need help or clarification on anything?

I don't believe so.

Which issue(s) does this PR fix?

Fixes #331. Or at least it's a start. 😀

@sdboyer
Copy link
Member

sdboyer commented Nov 28, 2017

ok so, we definitely want to do this 😄

i'll try for more review today or tomorrow, but in the meantime, do you think we could reasonably do some of those checkboxes in stages?

Copy link
Collaborator

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it, works and looks great.
I've left a few inline comments about the broken links. But I feel, since there's a lot of text, we can fix them gradually later. Maybe get help from the readers?

At this stage, the maintainers are most interested in feedback centered on the user experience (UX) of the tool.
Do you have workflows that the tool supports well, or doesn't support at all?
Do any of the commands have surprising effects, output, or results?
Please check the existing issues and [FAQ](docs/FAQ.md) to see if your feedback has already been reported.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link seems to be broken. [FAQ](faq) works.

- [User Stories](https://docs.google.com/document/d/1wT8e8wBHMrSRHY4UF_60GCgyWGqvYye4THvaDARPySs/edit)
- [Features](https://docs.google.com/document/d/1JNP6DgSK-c6KqveIhQk-n_HAw3hsZkL-okoleM43NgA/edit)
- [Design Space](https://docs.google.com/document/d/1TpQlQYovCoX9FkpgsoxzdvZplghudHAiQOame30A-v8/edit)
- [Frequently Asked Questions](docs/FAQ.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/FAQ.md -> faq


## Installing dependencies

(if your `vendor/` directory isn't [checked in with your code](docs/FAQ.md#should-i-commit-my-vendor-directory))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/FAQ.md -> /dep/faq#...

1. Back up your existing `vendor/` directory (if you have one) to
`_vendor-TIMESTAMP/`
1. Pick the highest compatible version for each dependency
1. Generate [`Gopkg.toml`](docs/Gopkg.toml.md) ("manifest") and `Gopkg.lock` files
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link would require docs/Gopkg.toml.md to be moved into docs/content/ and then change the link accordingly. Or maybe an external github link to the file.


This does the following:

1. Look for [existing dependency management files](docs/FAQ.md#what-external-tools-are-supported) to convert
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/FAQ.md -> /dep/faq#...

Contributions are greatly appreciated.
The maintainers actively manage the issues list, and try to highlight issues suitable for newcomers.
The project follows the typical GitHub pull request model.
See [CONTRIBUTING.md](CONTRIBUTING.md) for more details.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link would require moving CONTRIBUTING.md into docs/content/. Or maybe an external github link would be good for it.

/docs/_deploy/
/docs/_preview/
/docs/config.toml.bak
/hack/travis.deploy.pem
Copy link
Collaborator

@darkowlzz darkowlzz Nov 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end with newline

@carolynvs
Copy link
Collaborator Author

@sdboyer Yeah, all the checkboxes can be done later, though if we want deploys to work, adding the deploy key to the repo is not optional. Everything else can be done later and I think we should.

@sdboyer
Copy link
Member

sdboyer commented Dec 3, 2017

let's just get the deploy key in here, then. I'm not clear on what we need to do there, though - just enter it into Travis via their mechanism for secrets?

@carolynvs
Copy link
Collaborator Author

@sdboyer On the repo, click Settings -> Deploy Keys -> Add Deploy Key, then paste the public key from my pull request (below). The private key has been encrypted with the travis tool for this repo only, and can only be decrypted during a travis build on master (i.e. not forks).

https://github.com/golang/dep/pull/1369/files#diff-4792ccfc9d3ef656e9cb864451527ea5

@carolynvs
Copy link
Collaborator Author

Closing in favor of #1499

@carolynvs carolynvs closed this Jan 8, 2018
@sdboyer
Copy link
Member

sdboyer commented Jan 8, 2018

y'know i think actually we could probably set up docusaurus before the docs themselves are merged. just...not publicize it until it's got content there😁

@carolynvs
Copy link
Collaborator Author

@sdboyer Is that a hint? 😁

@sdboyer
Copy link
Member

sdboyer commented Jan 9, 2018

it was actually just musing, not a hint, sorry - though if you had time to take it as a hint, i would be the opposite of unhappy about it 😉

@carolynvs
Copy link
Collaborator Author

@sdboyer I'll trade you looking at my transitive constraints PR/proposal, in exchange for setting up docusaurus. :trollface:

@carolynvs carolynvs deleted the docs branch February 11, 2018 19:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create structure for managing docs
4 participants