This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
dep: Skip tool conversions in dep status #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collectConstraints(), used by `dep status`, was trying to do on-the-fly conversions of existing tools. That needs to remain disabled until we also turn it on for `dep init` and `dep ensure`.
|
@sdboyer thank you for fixing this. That code was added about 4 months ago without much thoughts and got passed on to the other commits. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
collectConstraints(), used by
dep status, was trying to do on-the-flyconversions of existing tools. That needs to remain disabled until we
also turn it on for
dep initanddep ensure.