Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Proposal: Allow transitive constraints #1489

Closed
wants to merge 6 commits into from
Closed

Proposal: Allow transitive constraints #1489

wants to merge 6 commits into from

Commits on Jan 25, 2018

  1. gps: apply transitive constraints

    @carolynvs @carolynvs-msft
    carolynvs authored and carolynvs-msft committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    c496efc View commit details
    Browse the repository at this point in the history

  2. Test dep ensure with a transitive constraint

    @carolynvs @carolynvs-msft
    carolynvs authored and carolynvs-msft committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    00ede10 View commit details
    Browse the repository at this point in the history

  3. Test dep init with a transitive constraint

    @carolynvs @carolynvs-msft
    carolynvs authored and carolynvs-msft committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    e075a3f View commit details
    Browse the repository at this point in the history

  4. Failing test for unused transitive constraint

    @carolynvs @carolynvs-msft
    carolynvs authored and carolynvs-msft committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    5b8fdcb View commit details
    Browse the repository at this point in the history

  5. NEEDS REVIEW: DO NOT MERGE 

    This is a prototype for keeping track of the path through the selection
process to a project. It is used to help dep ignore "stale" transitive
constraints: constraints that when created applied to a descendent but
should no longer apply now that that the project has moved to another
location in the dependency graph.

Questions:
* I put bmi on atomWithPackages because it already had a bmi method to
recreate the original bmi. Not sure if it's safe to live there
considering the comments on the original bmi function about avoiding
copys of the package list. So it may need to shift elsewhere or path
should be be split out from the bmi struct so that it can be attached
directly to an atom.
* Is a non-bimodal solve ever a possibility in dep (outside of the unit
tests?). I think we could drop "dep.isTransitive" in favor of using
bmi.path exclusively but the unit tests have a non-bimodal set of tests
that cause this to fail.
    @carolynvs @carolynvs-msft
    carolynvs authored and carolynvs-msft committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    0b71dd2 View commit details
    Browse the repository at this point in the history

  6. Update exists (pre-PR) tests to pass 

    One test relied upon constraints NOT being applied transitively. The
other was named incorrectly, it was testing a non-root scenario but was
named "transitive" which was misleading.
    @carolynvs @carolynvs-msft
    carolynvs authored and carolynvs-msft committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    d93117f View commit details
    Browse the repository at this point in the history