Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

[WIP] Ignore NoGoCode errors from required packages #1545

Closed

Commits on Jan 17, 2018

  1. NEEDS REVIEW: DO NOT MERGE

    This is a prototype for keeping track of the path through the selection
    process to a project. It is used to help dep ignore "stale" transitive
    constraints: constraints that when created applied to a descendent but
    should no longer apply now that that the project has moved to another
    location in the dependency graph.
    
    Questions:
    * I put bmi on atomWithPackages because it already had a bmi method to
    recreate the original bmi. Not sure if it's safe to live there
    considering the comments on the original bmi function about avoiding
    copys of the package list. So it may need to shift elsewhere or path
    should be be split out from the bmi struct so that it can be attached
    directly to an atom.
    * Is a non-bimodal solve ever a possibility in dep (outside of the unit
    tests?). I think we could drop "dep.isTransitive" in favor of using
    bmi.path exclusively but the unit tests have a non-bimodal set of tests
    that cause this to fail.
    carolynvs authored and carolynvs-msft committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    3a329b9 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2018

  1. Configuration menu
    Copy the full SHA
    1953152 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8788c93 View commit details
    Browse the repository at this point in the history
  3. Make codeclimate happy

    carolynvs-msft committed Jan 18, 2018
    Configuration menu
    Copy the full SHA
    60af0f1 View commit details
    Browse the repository at this point in the history