Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Missing quotes added #2017

Closed
wants to merge 1 commit into from
Closed

Missing quotes added #2017

wants to merge 1 commit into from

Conversation

gabolaev
Copy link

Hey there!
In the quote, which is given to explain the meaning of the dep ensure, a quotation mark is omitted in a figurative reference to the dep.

Missing quotes added
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

1 similar comment
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@gabolaev
Copy link
Author

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@gabolaev
Copy link
Author

gabolaev commented Sep 24, 2018

Hmm, why @googlebot duplicates its messages?

@gabolaev
Copy link
Author

gabolaev commented Feb 4, 2019

guys?(

kevinburke added a commit that referenced this pull request Mar 9, 2019
Originally submitted by George Gabolaev <gabolaev98@gmail.com> as
PR #2017. George has signed the CLA.
kevinburke added a commit that referenced this pull request Mar 9, 2019
Originally submitted by George Gabolaev <gabolaev98@gmail.com> as
PR #2017. George has signed the CLA.
@kevinburke kevinburke closed this Mar 9, 2019
@kevinburke
Copy link
Collaborator

This has been merged!

lhauspie pushed a commit to lhauspie/dep that referenced this pull request Apr 9, 2019
Originally submitted by George Gabolaev <gabolaev98@gmail.com> as
PR golang#2017. George has signed the CLA.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants