Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

add version command #210

Closed
wants to merge 3 commits into from
Closed

add version command #210

wants to merge 3 commits into from

Conversation

mattn
Copy link
Member

@mattn mattn commented Jan 31, 2017

Displaying only version string because it may be used from shell. If you want verbosy messages, I'll fix this. (#209)

.gitignore Outdated
@@ -2,5 +2,6 @@
# if you want to ignore files created by your editor/tools,
# please consider a global .gitignore https://help.github.com/articles/ignoring-files
# please do not open a pull request to add something created by your editor or tools
dep
cmd/dep/dep
cmd/dep/dep.exe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont people just compile it in the project root?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see this change. That 'dep' line in .gitignore causes Atom, at least, to disconnect its git montioring from the cmd/dep lib. I keep removing the line and being sure not to check in the change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file version.go I've added was ignored by .gitignore. However @jessfraz is right. I updated .gitignore to avoid both.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thx

ignore dep command in somewhere
@freeformz freeformz closed this Feb 2, 2017
@freeformz freeformz reopened this Feb 2, 2017
@adg
Copy link
Contributor

adg commented Feb 3, 2017

Can we please put this on hold until we actually have version tags and some kind of release infrastructure in place?

@mattn
Copy link
Member Author

mattn commented Feb 3, 2017

Sure. I also thinking this p-r makes annoying. I don't mind close this. Feel free to close if you want. :)

@mattn
Copy link
Member Author

mattn commented Feb 3, 2017

Or, could you please cherry-pick second commit? currently, adding files into cmd/dep/* is ignored.

@freeformz
Copy link

@mattn I fixed that in e93d9b5

@freeformz freeformz closed this Feb 3, 2017
@freeformz
Copy link

I'll close this for now, but we can re-evaluate when we're ready for a release process.

@mattn mattn deleted the version branch February 3, 2017 00:48
@sdboyer sdboyer mentioned this pull request Mar 7, 2017
krisnova pushed a commit to krisnova/dep that referenced this pull request Apr 21, 2017
Convert ListVersions() to return []PairedVersion
@ibrasho ibrasho mentioned this pull request May 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants