This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Update gps to v0.16.0 #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Putting this one in. Huzzah! |
ibrasho
pushed a commit
to ibrasho-forks/dep
that referenced
this pull request
May 10, 2017
Update gps to v0.16.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates us to gps v0.16.0. The most noteworthy changes are not API-visible; it exerts more careful control over running subprocesses, which could be sufficient for us to do #301. Also, sdboyer/gps#196 is in, which should put an end to the race conditions. That should help out #378, and probably fix a number of others.
This MAY cause a performance regression, owing to when we hit the network for source version information. If it does, though, it'll be a fleeting problem - the refactored
sourceMgrgives us lots of performance headroom now!