This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Drop remove subcommand #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
easy enough, though I want to pump the breaks on this one for a second - just enough for a pass over the CLI help text to make sure there are no references to anything like this command's behavior (removing items from the manifest), either implicit or explicit. |
|
Rebase for feature branch integration, please 😄 |
darkowlzz
force-pushed
the
481-drop-remove-subcommand
branch
from
237d735
to
0a8a4d1
Compare
|
@sdboyer rebased onto current master :) |
|
I never actually made the feature branch for this, and I'm likely not to do so, as I'd rather just merge these directly. So...one more rebase? 😄 |
Removes remove.go along with all the test files and harness tests.
darkowlzz
force-pushed
the
481-drop-remove-subcommand
branch
from
0a8a4d1
to
abcd78e
Compare
|
rebased! 😁 |
|
excellent - thank you 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes remove.go along with all the test files and harness tests.
Fixes #481