dep: unexport Manifest.Ignored #594
Conversation
Manifest.Ignored should be accessed via the IgnoredPackages() helper which returns a copy of the field as a map.
|
Without a function that allows an external package to construct a Also, rather than these individual PRs, can we have that discussion about an export policy (in an issue dedicated to it)? It seems clear you have some guiding principles you're operating by, and it would be good to make this explicit. |
|
My rationale is the same as the desire to move packages to dep/internal;
anything that is exported in a non main package is part of the public API
for this project. The smaller the surface area, the smaller the chance of
breaking someone who depends on this package.
…On Wed, May 17, 2017 at 11:31 AM, sam boyer ***@***.***> wrote:
Without a function that allows an external package to construct a Manifest
with arbitrary values (including ones for this value), I think I'd prefer
to leave these properties exported.
Also, rather than these individual PRs, can we have that discussion about
an export policy (in an issue dedicated to it)? It seems clear you have
some guiding principles you're operating by, and it would be good to make
this explicit.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#594 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAcAwVuuWdWNpjAKIJRXYPXEjEl5SdQks5r6k3xgaJpZM4NdQ6o>
.
|
|
That's an accurate functional statement, of course. But as a policy, it addresses only one of the relevant factors - minimizing surface area. On its own, we'd rapidly reach the point where we export nothing at all. The question that we need to answer is what we want the surface area to be, and how that relates to a release process. I could certainly be convinced that the right position for now is to be conservative and export absolutely nothing publicly. But I want us to set a goal, even a loose one, and move towards it, rather than iterating without a plan. |
|
Closing this - to the extent we've articulated a policy, it does include exporting |
Manifest.Ignored should be accessed via the IgnoredPackages() helper
which returns a copy of the field as a map.