Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

unexport and re-locate PruneProject and helpers #716

Merged
merged 1 commit into from
Jul 13, 2017
Merged

unexport and re-locate PruneProject and helpers #716

merged 1 commit into from
Jul 13, 2017

Conversation

jmank88
Copy link
Collaborator

@jmank88 jmank88 commented Jun 3, 2017

This change unexports the PruneProject function and moves it and associated helpers into prune.go, alongside the only usage.
#672

@jmank88 jmank88 closed this Jun 4, 2017
@jmank88 jmank88 reopened this Jun 4, 2017
@jmank88
Copy link
Collaborator Author

jmank88 commented Jun 22, 2017

Bump for review

@jmank88
Copy link
Collaborator Author

jmank88 commented Jul 12, 2017

Rebased.

@jmank88 jmank88 closed this Jul 13, 2017
@jmank88 jmank88 reopened this Jul 13, 2017
Copy link
Collaborator

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once the build is fixed 👍

@@ -0,0 +1,42 @@
package main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the license header here? This would fix the breaking travis build.

Copy link
Collaborator

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darkowlzz darkowlzz merged commit fc00707 into golang:master Jul 13, 2017
@darkowlzz
Copy link
Collaborator

Thanks for the PR :)

@jmank88 jmank88 deleted the unexport_prune_project branch July 13, 2017 17:20
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants