This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
gps: add new ProjectAnalyzerInfo type to return from ProjectAnalyzer.Info #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdboyer
suggested changes
Jun 14, 2017
internal/gps/source_manager.go
Outdated
| Info() ProjectAnalyzerInfo | ||
| } | ||
|
|
||
| // ProjectAnalyzerInfo holds name and version information for a ProjectAnalyzer. |
There was a problem hiding this comment.
small modification: "ProjectAnalyzerInfo indicates a ProjectAnalyzer's name and version."
sdboyer
approved these changes
Jun 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This PR proposes a new simple struct type
ProjectAnalyzerInfoto return fromProjectAnalyzer.Info(), and to use in place ofProjectAnalyzerin a few places which only calledInfo(). My working branch for #431 contains additional usages.What should your reviewer look out for in this PR?
Better name or documentation opportunities. More usages of
ProjectAnalyzerwhich only needProjectAnalyzerInfo.Which issue(s) does this PR fix?
Related #672 and #431.