This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
use different timeouts for all vcs commands #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both `runFromRepoDir` and `runFromCwd` accept now a timeout to control the timeouts of the underlying `monitoredCmd`, instead of having a hardcoded timeout of 2 minutes for all commands. This will allow better tuning of the timeouts on a per-command basis. Signed-off-by: Miguel Molina <miguel@erizocosmi.co>
sdboyer
approved these changes
Jul 23, 2017
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
both
runFromRepoDirandrunFromCwdaccept now a timeout to control the timeouts of the underlyingmonitoredCmd, instead of having a hardcoded timeout of 2 minutes for all commands.This will allow better tuning of the timeouts on a per-command basis.
Right now, as the timeouts are really naive I've just added two kinds of timeouts:
expensiveCmdTimeout: a cmd that is expensive such as clones, fetches, updates, ...defaultCmdTimeout: any other non-remote or non-expensive cmdI expect these to change during the review when the timeouts are better adjusted, anyway 😛
What should your reviewer look out for in this PR?
The timeouts are a bit naive right now. I am familiar with git commands but not with all other vcs commands, so the rule I followed was: remote -> expensive, non-remote -> default timeout. So if you see a timeout that seems a bit off, tell me so I can adjust it 😄
Do you need help or clarification on anything?
Basically just check the timeouts, specially on non-git vcs's.
Which issue(s) does this PR fix?
Fixes #872