This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
fix(status): tableOutput show override constraints #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't added tests yet. Will add them once we decide how to correctly implement and show the results. |
sdboyer
suggested changes
Aug 10, 2017
cmd/dep/status.go
Outdated
| @@ -95,6 +95,9 @@ func (out *tableOutput) BasicLine(bs *BasicStatus) { | |||
| } else { | |||
| constraint = bs.Constraint.String() | |||
| } | |||
| if bs.hasOverride { | |||
| constraint += "(override)" | |||
Add `hasOverride` attribute to `BasicStatus` struct and use it to append "(override)" to projects with overridden constraints. Closes golang#892
Add integration test for tableOutput show override constraints.
darkowlzz
force-pushed
the
892-status-overrides
branch
from
21abe6a to
fbbac80
Compare
sdboyer
approved these changes
Aug 11, 2017
|
@darkowlzz merge away! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
Adds
hasOverrideattribute toBasicStatusstruct and use it to append"(override)" to projects with overridden constraints.
What should your reviewer look out for in this PR?
The way overridden constraints are tracked in
BasicStatus.Do you need help or clarification on anything?
Would this be a good way to show overridden constraints?
Which issue(s) does this PR fix?
Fixes #892