This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Use fork of Masterminds/semver until PR is merged #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the godep testdata now that dep correctly converts a version with multiple dashes into a caret, instead of a bad range.
|
yes, no issue with relying on the fork. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
Use fix from PR Masterminds/semver#60 until it is merged (or Masterminds/semver#59 is otherwise fixed upstream).
What should your reviewer look out for in this PR?
Do we want to use a PR that we aren't sure will be merged?
Do you need help or clarification on anything?
Nope!
Which issue(s) does this PR fix?
I am not sure if we have an existing issue but it was found when was working through what we need to fix in order for a project like kuberentes to use dep. See fabulous-gopher/k8s-dep-e2e#3.
Fixes #924