This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Fix missing branch in dep ensure -add: introduce hoist from lock #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdboyer
changed the title
sdboyer
changed the title
|
LGTM from a quick glance. QQ: Is there any possibility that |
not if we successfully found a solution. i was thinking about this while coding it, though. i'll add a panic for that case - better to be explicit. |
|
ok, goin in |
|
I think we still need to resolve manifest verification just in case we create an invalid manifest somehow. |
|
@ibrasho oh, for sure - just, separate issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This completes a major bit of #489 that was missing - converting whatever's in the lock to a constraint that we can append into
Gopkg.tomlwhen no version constraint was given on the CLI.What should your reviewer look out for in this PR?
This was easier than i thought it would be. Have i missed something?