Skip to content

Commit

Permalink
os/exec: disable failing LookPathTest on windows/arm64
Browse files Browse the repository at this point in the history
For #44379.

Change-Id: I9a3cf4d511a8286117f877c2ff9dbde56fa55983
Reviewed-on: https://go-review.googlesource.com/c/go/+/293709
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Trust: Russ Cox <rsc@golang.org>
  • Loading branch information
rsc committed Feb 19, 2021
1 parent b445d6e commit 40765ff
Showing 1 changed file with 12 additions and 7 deletions.
19 changes: 12 additions & 7 deletions src/os/exec/lp_windows_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ func (test lookPathTest) run(t *testing.T, tmpdir, printpathExe string) {
if errCmd == nil && errLP == nil {
// both succeeded
if should != have {
t.Fatalf("test=%+v failed: expected to find %q, but found %q", test, should, have)
t.Fatalf("test=%+v:\ncmd /c ran: %s\nlookpath found: %s", test, should, have)
}
return
}
Expand Down Expand Up @@ -316,12 +316,17 @@ func TestLookPath(t *testing.T) {

// Run all tests.
for i, test := range lookPathTests {
dir := filepath.Join(tmp, "d"+strconv.Itoa(i))
err := os.Mkdir(dir, 0700)
if err != nil {
t.Fatal("Mkdir failed: ", err)
}
test.run(t, dir, printpathExe)
t.Run(fmt.Sprint(i), func(t *testing.T) {
if i == 16 {
t.Skip("golang.org/issue/44379")
}
dir := filepath.Join(tmp, "d"+strconv.Itoa(i))
err := os.Mkdir(dir, 0700)
if err != nil {
t.Fatal("Mkdir failed: ", err)
}
test.run(t, dir, printpathExe)
})
}
}

Expand Down

0 comments on commit 40765ff

Please sign in to comment.