Skip to content

Commit

Permalink
runtime/pprof: disable TestMorestack on darwin/arm64
Browse files Browse the repository at this point in the history
Something is weird about darwin and TestMorestack,
but it is only manifesting on arm64 and race+amd64.
Disable for now.

Change-Id: I5862372fdd0b5ffae802fdefb65b2aa04e266fcc
Reviewed-on: https://go-review.googlesource.com/c/go/+/294409
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
  • Loading branch information
rsc committed Feb 20, 2021
1 parent 078f08f commit a8942d2
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/runtime/pprof/pprof_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,11 @@ func TestMorestack(t *testing.T) {
// https://build.golang.org/log/280d387327806e17c8aabeb38b9503dbbd942ed1
t.Skip("skipping on darwin race detector")
}
if runtime.GOOS == "darwin" && runtime.GOARCH == "arm64" {
// For whatever reason, darwin/arm64 also doesn't work.
// https://build.golang.org/log/c45e82cc25f152642e6fb90d882ef5a8cd130ce5
t.Skip("skipping on darwin/arm64")
}
testCPUProfile(t, stackContainsAll, []string{"runtime.newstack,runtime/pprof.growstack"}, avoidFunctions(), func(duration time.Duration) {
t := time.After(duration)
c := make(chan bool)
Expand Down

0 comments on commit a8942d2

Please sign in to comment.