Skip to content

Commit

Permalink
cmd/dist: add buildtag parsing test
Browse files Browse the repository at this point in the history
Forgot to 'git add' this test written as part of CL 359314.

For #41184.

Change-Id: I2ebd48fd62a2053c8b16e5a8c48c1e11d1b86d5b
Reviewed-on: https://go-review.googlesource.com/c/go/+/366894
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
  • Loading branch information
rsc committed Nov 25, 2021
1 parent b77f5f9 commit b2a5a37
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 3 deletions.
43 changes: 43 additions & 0 deletions src/cmd/dist/buildtag_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
// Copyright 2021 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

package main

import (
"fmt"
"reflect"
"testing"
)

var buildParserTests = []struct {
x string
matched bool
err error
}{
{"gc", true, nil},
{"gccgo", false, nil},
{"!gc", false, nil},
{"gc && gccgo", false, nil},
{"gc || gccgo", true, nil},
{"gc || (gccgo && !gccgo)", true, nil},
{"gc && (gccgo || !gccgo)", true, nil},
{"!(gc && (gccgo || !gccgo))", false, nil},
{"gccgo || gc", true, nil},
{"!(!(!(gccgo || gc)))", false, nil},
{"compiler_bootstrap", false, nil},
{"cmd_go_bootstrap", true, nil},
{"syntax(error", false, fmt.Errorf("parsing //go:build line: unexpected (")},
{"(gc", false, fmt.Errorf("parsing //go:build line: missing )")},
{"gc gc", false, fmt.Errorf("parsing //go:build line: unexpected tag")},
{"(gc))", false, fmt.Errorf("parsing //go:build line: unexpected )")},
}

func TestBuildParser(t *testing.T) {
for _, tt := range buildParserTests {
matched, err := matchexpr(tt.x)
if matched != tt.matched || !reflect.DeepEqual(err, tt.err) {
t.Errorf("matchexpr(%q) = %v, %v; want %v, %v", tt.x, matched, err, tt.matched, tt.err)
}
}
}
6 changes: 3 additions & 3 deletions src/cmd/go/go_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1128,11 +1128,11 @@ func TestGoListTest(t *testing.T) {
tg.grepStdoutNot(`^testing \[sort.test\]$`, "unexpected test copy of testing")
tg.grepStdoutNot(`^testing$`, "unexpected real copy of testing")

tg.run("list", "-test", "cmd/dist", "cmd/doc")
tg.grepStdout(`^cmd/dist$`, "missing cmd/dist")
tg.run("list", "-test", "cmd/buildid", "cmd/doc")
tg.grepStdout(`^cmd/buildid$`, "missing cmd/buildid")
tg.grepStdout(`^cmd/doc$`, "missing cmd/doc")
tg.grepStdout(`^cmd/doc\.test$`, "missing cmd/doc test")
tg.grepStdoutNot(`^cmd/dist\.test$`, "unexpected cmd/dist test")
tg.grepStdoutNot(`^cmd/buildid\.test$`, "unexpected cmd/buildid test")
tg.grepStdoutNot(`^testing`, "unexpected testing")

tg.run("list", "-test", "runtime/cgo")
Expand Down

0 comments on commit b2a5a37

Please sign in to comment.