Skip to content

Commit

Permalink
cmd/go/internal/modload: change Requirements.graph type to atomic.Poi…
Browse files Browse the repository at this point in the history
…nter[cachedGraph]
  • Loading branch information
Abirdcfly committed Sep 7, 2022
1 parent ccf82d5 commit ed993db
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions src/cmd/go/internal/modload/buildlist.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ type Requirements struct {
// nested module back into a parent module).
direct map[string]bool

graphOnce sync.Once // guards writes to (but not reads from) graph
graph atomic.Value // cachedGraph
graphOnce sync.Once // guards writes to (but not reads from) graph
graph atomic.Pointer[cachedGraph]
}

// A cachedGraph is a non-nil *ModuleGraph, together with any error discovered
Expand Down Expand Up @@ -199,7 +199,7 @@ func (rs *Requirements) initVendor(vendorList []module.Version) {
mg.g.Require(vendorMod, vendorList)
}

rs.graph.Store(cachedGraph{mg, nil})
rs.graph.Store(&cachedGraph{mg, nil})
})
}

Expand Down Expand Up @@ -240,9 +240,9 @@ func (rs *Requirements) hasRedundantRoot() bool {
func (rs *Requirements) Graph(ctx context.Context) (*ModuleGraph, error) {
rs.graphOnce.Do(func() {
mg, mgErr := readModGraph(ctx, rs.pruning, rs.rootModules)
rs.graph.Store(cachedGraph{mg, mgErr})
rs.graph.Store(&cachedGraph{mg, mgErr})
})
cached := rs.graph.Load().(cachedGraph)
cached := rs.graph.Load()
return cached.mg, cached.err
}

Expand Down
2 changes: 1 addition & 1 deletion src/cmd/go/internal/modload/load.go
Original file line number Diff line number Diff line change
Expand Up @@ -1837,7 +1837,7 @@ func (ld *loader) computePatternAll() (all []string) {
func (ld *loader) checkMultiplePaths() {
mods := ld.requirements.rootModules
if cached := ld.requirements.graph.Load(); cached != nil {
if mg := cached.(cachedGraph).mg; mg != nil {
if mg := cached.mg; mg != nil {
mods = mg.BuildList()
}
}
Expand Down

0 comments on commit ed993db

Please sign in to comment.