-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: add ability to download info, mod and source zip #26577
Comments
Is this the same thing as #26609? |
Yes, indeed. Sorry for the duplication - I hadn't seen this yet. |
would this be in the scope of being able to do something like |
@rsc what do you think about a @marwan-at-work mentioned today at the athens dev meeting that we might have to duplicate |
@arschles |
I wonder if we can add “don’t require go list -m to be in a go module” to
the wishlist on this issue 😊
…On Thu, Jul 26, 2018 at 11:52 Marwan Sulaiman ***@***.***> wrote:
@arschles <https://github.com/arschles> go list -m -versions already
works. We just have to be inside a dummy go module, which is a bit hacky :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26577 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAEU0avamQSCPoUZzBDsQVDiHWFRlI1Bks5uKhALgaJpZM4VfGit>
.
|
Should this be a release blocker just like its #26609 dup? |
Also from Athen's perspective, it's okay to just do all three at the same time (info/mod/zip). As long as Go doesn't traverse the dependencies of what we're asking for and tries to download them and "go install" them. This has led to some failed builds. |
Change https://golang.org/cl/128355 mentions this issue: |
In the Athens project, the code that downloads code from VCS's and stores it in the database uses
go get
behind the scenes. We have to do some hacky things right now - like create a skeletongo.mod
file and an emptyfunc main() {}
to getgo get
to work.Instead of doing that, we'd like to use a command - say,
go get $THING --artifacts-only
- that downloads the code from the appropriate VCS (still respecting redirects, etc... as it does now), creates the source zip, and then leaves just the info, mod, and source zip in the current directory. and all of this without requiring that there is a validgo.mod
and any go code in the cwd.The text was updated successfully, but these errors were encountered: