Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: downloads page claims that Go 1.11 supports unsupported operating systems #27213

Closed
dominikh opened this issue Aug 25, 2018 · 7 comments
Closed

doc: downloads page claims that Go 1.11 supports unsupported operating systems #27213

dominikh opened this issue Aug 25, 2018 · 7 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.11.1

Comments

@dominikh
Copy link
Member

Support for Windows XP was removed in Go 1.11, but golang.org/dl/ still claims that it's supported:

2018-08-25-094036_485x239_scrot
@mariecurried
Copy link

The same happens for macOS, where the minimum version is now 10.10:
macos

@dominikh dominikh changed the title doc: downloads page claims that Go 1.11 supports Windows XP doc: downloads page claims that Go 1.11 supports unsupported operating systems Aug 25, 2018
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 25, 2018
@bradfitz bradfitz added this to the Go1.11.1 milestone Aug 25, 2018
@bradfitz
Copy link
Contributor

Actually I think this partly yet another duplicate of #27205.

The website is running a mix of Go 1.9 and Go 1.10 and Go 1.11. It's kinda a mess.

The text above is coming from the x/tools Go 1.10 branch. But the text is wrong even at tip, but fixing it won't fix it on the website until we fix #27205 also. I suppose we could cherry-pick the fixes back to Go 1.10.

Will send a change.

@bradfitz
Copy link
Contributor

/cc @andybons @dmitshur

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/131402 mentions this issue: godoc/dl: update Mac & Windows minimum versions

gopherbot pushed a commit to golang/tools that referenced this issue Aug 26, 2018
@bradfitz
godoc/dl: update Mac & Windows minimum versions
f6ba574 
Updates golang/go#27213

Change-Id: I25813e9aafcdb39d4f93e27b98d8672c770234a6
Reviewed-on: https://go-review.googlesource.com/131402
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/131403 mentions this issue: [release-branch.go1.10] godoc/dl: update Mac & Windows minimum versions

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/131404 mentions this issue: [release-branch.go1.11] godoc/dl: update Mac & Windows minimum versions

@gopherbot
Copy link
Contributor

Closed by merging 9e9bf16a4efe175e2867e1661feefa6278e4e14e to release-branch.go1.11.

gopherbot pushed a commit to golang/tools that referenced this issue Aug 26, 2018
@bradfitz @andybons
[release-branch.go1.11] godoc/dl: update Mac & Windows minimum versions
9e9bf16 
Updates golang/go#27213

Change-Id: I25813e9aafcdb39d4f93e27b98d8672c770234a6
Reviewed-on: https://go-review.googlesource.com/131402
Reviewed-by: Andrew Bonventre <andybons@golang.org>
(cherry picked from commit f6ba574)
Reviewed-on: https://go-review.googlesource.com/131404
gopherbot pushed a commit to golang/tools that referenced this issue Aug 26, 2018
@bradfitz @andybons
[release-branch.go1.10] godoc/dl: update Mac & Windows minimum versions
156d532 
Updates golang/go#27213

Change-Id: I25813e9aafcdb39d4f93e27b98d8672c770234a6
Reviewed-on: https://go-review.googlesource.com/131402
Reviewed-by: Andrew Bonventre <andybons@golang.org>
(cherry picked from commit 1057b4d)
Reviewed-on: https://go-review.googlesource.com/131403
@golang golang locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.11.1
Development

No branches or pull requests
5 participants
@bradfitz @dominikh @dmitshur @gopherbot @mariecurried