cmd/compile: fixedbugs/issue7921.go failing on noopt builder

[ALTree]

The fixedbugs/issue7921.go test is currently failing on the noopt builder. To reproduce the failure:

$ gotip install -a -gcflags="-N -l" std
$ cd test
$ gotip run run.go -- fixedbugs/issue7921.go
# go run run.go -- fixedbugs/issue7921.go

issue7921.go:21: missing error "inlining call"
issue7921.go:21: missing error "string\\(bytes\\.b\\.buf\\[bytes.b.off:\\]\\) escapes to heap"
issue7921.go:25: no match for `inlining call` in:
	issue7921.go:25: make([]byte, 0, 64) escapes to heap
issue7921.go:25: no match for `make\(\[\]byte, 0, 64\) does not escape` in:
	issue7921.go:25: make([]byte, 0, 64) escapes to heap
issue7921.go:25: no match for `&bytes.Buffer literal does not escape` in:
	issue7921.go:25: make([]byte, 0, 64) escapes to heap
issue7921.go:29: missing error "inlining call"
issue7921.go:33: no match for `inlining call` in:
	issue7921.go:33: make([]byte, 0, 64) escapes to heap
issue7921.go:33: no match for `make\(\[\]byte, 0, 64\) does not escape` in:
	issue7921.go:33: make([]byte, 0, 64) escapes to heap
issue7921.go:33: no match for `&bytes.Buffer literal does not escape` in:
	issue7921.go:33: make([]byte, 0, 64) escapes to heap
issue7921.go:38: missing error "inlining call"
issue7921.go:38: missing error "string\\(bytes.b.buf\\[bytes\\.b\\.off:\\]\\) escapes to heap"
issue7921.go:45: no match for `inlining call` in:
	issue7921.go:45: bufferNoEscape4 b does not escape
issue7921.go:49: no match for `inlining call` in:
	issue7921.go:49: make([]byte, 0, 128) escapes to heap
issue7921.go:49: no match for `make\(\[\]byte, 0, 128\) does not escape` in:
	issue7921.go:49: make([]byte, 0, 128) escapes to heap
issue7921.go:49: no match for `&bytes.Buffer literal does not escape` in:
	issue7921.go:49: make([]byte, 0, 128) escapes to heap
Unmatched Errors:
issue7921.go:25: make([]byte, 0, 64) escapes to heap
issue7921.go:33: make([]byte, 0, 64) escapes to heap
issue7921.go:49: make([]byte, 0, 128) escapes to heap

FAIL	fixedbugs/issue7921.go	0.013s
exit status 1

https://build.golang.org/log/7a86ac7b3725a69c8bed216053356629c79141d3

[ALTree]

It's likely that this was broken from the start on the noopt builder. The test was added ~2 weeks ago, but at the time the noopt builder was already broken (for other reasons), so the commiter didn't notice that their test was failing on noopt.

[randall77]

We probably want to just skip "errorcheck -m" tests if "-N" (and/or "-l") is in GO_GCFLAGS.

[bradfitz]

@randall77, on its way.

[gopherbot]

Change https://golang.org/cl/136898 mentions this issue: test: skip some tests on noopt builder