Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: linux-amd64-noopt builder broken #27834

Closed
bradfitz opened this issue Sep 24, 2018 · 3 comments
Closed

build: linux-amd64-noopt builder broken #27834

bradfitz opened this issue Sep 24, 2018 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bradfitz
Copy link
Contributor

After https://go-review.googlesource.com/136855 the noopt builder is now broken with:

https://build.golang.org/log/9da226d6f602b11ab5a19b4fd54768d7ec8abc28

##### ../test
# go run run.go -- fixedbugs/issue7921.go

issue7921.go:21: missing error "inlining call"
issue7921.go:21: missing error "string\\(bytes\\.b\\.buf\\[bytes.b.off:\\]\\) escapes to heap"
issue7921.go:25: no match for `inlining call` in:
	issue7921.go:25: make([]byte, 0, 64) escapes to heap
issue7921.go:25: no match for `make\(\[\]byte, 0, 64\) does not escape` in:
	issue7921.go:25: make([]byte, 0, 64) escapes to heap
issue7921.go:25: no match for `&bytes.Buffer literal does not escape` in:
	issue7921.go:25: make([]byte, 0, 64) escapes to heap
issue7921.go:29: missing error "inlining call"
issue7921.go:33: no match for `inlining call` in:
	issue7921.go:33: make([]byte, 0, 64) escapes to heap
issue7921.go:33: no match for `make\(\[\]byte, 0, 64\) does not escape` in:
	issue7921.go:33: make([]byte, 0, 64) escapes to heap
issue7921.go:33: no match for `&bytes.Buffer literal does not escape` in:
	issue7921.go:33: make([]byte, 0, 64) escapes to heap
issue7921.go:38: missing error "inlining call"
issue7921.go:38: missing error "string\\(bytes.b.buf\\[bytes\\.b\\.off:\\]\\) escapes to heap"
issue7921.go:45: no match for `inlining call` in:
	issue7921.go:45: bufferNoEscape4 b does not escape
issue7921.go:49: no match for `inlining call` in:
	issue7921.go:49: make([]byte, 0, 128) escapes to heap
issue7921.go:49: no match for `make\(\[\]byte, 0, 128\) does not escape` in:
	issue7921.go:49: make([]byte, 0, 128) escapes to heap
issue7921.go:49: no match for `&bytes.Buffer literal does not escape` in:
	issue7921.go:49: make([]byte, 0, 128) escapes to heap
Unmatched Errors:
issue7921.go:25: make([]byte, 0, 64) escapes to heap
issue7921.go:33: make([]byte, 0, 64) escapes to heap
issue7921.go:49: make([]byte, 0, 128) escapes to heap

FAIL	fixedbugs/issue7921.go	0.047s
2018/09/24 17:35:33 Failed: exit status 1
2018/09/24 17:35:33 FAILED

Maybe we do want https://go-review.googlesource.com/c/go/+/136898 after all.

/cc @ALTree

@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Sep 24, 2018
@bradfitz bradfitz added this to the Go1.12 milestone Sep 24, 2018
@ALTree
Copy link
Member

ALTree commented Sep 24, 2018

This is #27833

@ALTree
Copy link
Member

ALTree commented Sep 24, 2018

The underlying issue is likely the same (issue7921.go has an external dep on the bytes package). At this point I agree we may want a way to skip tests on noopt with a tag.

@bradfitz
Copy link
Contributor Author

Closing in favor of #27833

@golang golang locked and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

3 participants