Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: write Go 1.15 release notes #37419

Closed
dmitshur opened this issue Feb 24, 2020 · 60 comments
Closed

doc: write Go 1.15 release notes #37419

dmitshur opened this issue Feb 24, 2020 · 60 comments
Labels
Documentation FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. recurring Issues that should never be closed, but moved to the next milestone once fixed in the current one. release-blocker
Milestone
Go1.15

Comments

@dmitshur
Copy link
Contributor

Tracking bug for writing the Go 1.15 Release Notes.

The latest state on tip can be viewed at https://tip.golang.org/doc/go1.15.

Previously #36878, #17929, #15810, #5929, etc.
@dmitshur dmitshur added Documentation help wanted NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Feb 24, 2020
@dmitshur dmitshur added this to the Go1.15 milestone Feb 24, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/227997 mentions this issue: doc/go1.15, net/url: document new method URL.Redacted

gopherbot pushed a commit that referenced this issue Apr 12, 2020
@odeke-em
doc/go1.15, net/url: document new method URL.Redacted
83bfe3b 
Adds an entry in the Go1.15 release notes, but also
adds an example test for URL.Redacted.

Follow-up of CL 207082.

Updates #37419

Change-Id: Ibf81989778907511a3a3a3e4a03d1802b5dd9762
Reviewed-on: https://go-review.googlesource.com/c/go/+/227997
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@ainar-g
Copy link
Contributor

ainar-g commented Apr 28, 2020

I think, the changes to the database/... packages should be documented as well: 

+pkg database/sql, method (*DB) SetConnMaxIdleTime(time.Duration)
+pkg database/sql, method (*Row) Err() error
+pkg database/sql, type DBStats struct, MaxIdleTimeClosed int64
+pkg database/sql/driver, type Validator interface { IsValid }
+pkg database/sql/driver, type Validator interface, IsValid() bool

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/235580 mentions this issue: doc/go1.15: document no language changes

gopherbot pushed a commit that referenced this issue May 28, 2020
@dmitshur
doc/go1.15: document no language changes
5a00adf 
There are no language changes in Go 1.15, so document that.

For #37419.

Change-Id: I1e96e58b701f1758d64c79881dfa0b1109836b83
Reviewed-on: https://go-review.googlesource.com/c/go/+/235580
Reviewed-by: Robert Griesemer <gri@golang.org>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/235757 mentions this issue: doc: update Go 1.15 release notes using relnote

gopherbot pushed a commit that referenced this issue Jun 1, 2020
@toothrot
doc/go1.15: update Go 1.15 release notes using relnote
eecc628 
The additions were generated using golang.org/x/build/cmd/relnote.

Updates #37419

Change-Id: Iad7b564dd7e6cbcbd0d216c2530802e086ec49cd
Reviewed-on: https://go-review.googlesource.com/c/go/+/235757
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/236157 mentions this issue: doc/go1.15: add release notes for strconv

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/236158 mentions this issue: doc/go1.15: add release notes for time

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/236159 mentions this issue: doc/go1.15: release notes for new linker

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/236160 mentions this issue: doc/go1.15: remove TODOs for tools and go command sections

gopherbot pushed a commit that referenced this issue Jun 2, 2020
doc/go1.15: remove TODOs for tools and go command sections
c082c1f 
For #37419

Change-Id: I35a5cf86ff09a3962959627dce58155b26ad4748
Reviewed-on: https://go-review.googlesource.com/c/go/+/236160
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/236162 mentions this issue: doc/go1.15: add release notes for plugin DWARF

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/236166 mentions this issue: doc/go1.15: add release notes for crypto/tls

gopherbot pushed a commit that referenced this issue Jun 3, 2020
@thanm
doc/go1.15: add release notes for new linker
9326d71 
Add a blurb to the release notes describing improvements made to the
Go linker in the most recent development cycle.

Updates #37419.

Change-Id: I3b870f0c00efc0b7b33aab2631d8c4e1c273922d
Reviewed-on: https://go-review.googlesource.com/c/go/+/236159
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit that referenced this issue Jun 3, 2020
@thanm
doc/go1.15: add release notes for plugin
7a2632e 
Add a blurb to the release notes mentioning that the
linker now supports DWARF generation for -buildmode=plugin,
and that plugin builds work now for freebsd/amd64.

Updates #37419.

Change-Id: I84da7a52af84a9d765f73ca7ea525e7af8d64f05
Reviewed-on: https://go-review.googlesource.com/c/go/+/236162
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/236417 mentions this issue: doc/go1.15: add release notes for fmt

gopherbot pushed a commit that referenced this issue Jun 4, 2020
@julieqiu
doc/go1.15: add release notes for strconv
cb5fad7 
Updates #37419

Change-Id: Ic72bf0da914fa8a56570750b8fd4b4d09d2ed075
Reviewed-on: https://go-review.googlesource.com/c/go/+/236157
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit that referenced this issue Jun 4, 2020
@julieqiu
doc/go1.15: add release notes for time
bdf76ca 
Updates #37419

Change-Id: I2018b55f335400070bfa3573adab9549a5bf6a1a
Reviewed-on: https://go-review.googlesource.com/c/go/+/236158
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/236658 mentions this issue: doc/go1.15: add release notes for io/ioutil

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/236719 mentions this issue: doc/go1.15: exclude spaces from <code> block

gopherbot pushed a commit that referenced this issue Jun 5, 2020
@aclements
doc/go1.15: exclude spaces from <code> block
76f233f 
Per the note at the top of go1.15.html.

Updates #37419.

Change-Id: Ia6917347ca1e3ebe8c55f9c0ec74e49ff481a64f
Reviewed-on: https://go-review.googlesource.com/c/go/+/236719
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/236682 mentions this issue: doc/go1.15: mention new debug/pe constants

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/236718 mentions this issue: doc/go1.15: rationalize runtime sections

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/236618 mentions this issue: doc/go1.15: document toolchain changes

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/243137 mentions this issue: doc/go1.15: announce GO386=387 deprecation

gopherbot pushed a commit that referenced this issue Jul 17, 2020
@dmitshur
go/printer: remove exported StdFormat flag
6f26480 
The StdFormat flag was added as part of CL 231461, where the primary aim
was to fix the bug #37476. It's expected that the existing printer modes
only adjust spacing but do not change any of the code text itself. A new
printing flag served as a way for cmd/gofmt and go/format to delegate
a part of formatting work to the printer—where it's more more convenient
and efficient to perform—while maintaining current low-level printing
behavior of go/printer unmodified.

We already have cmd/gofmt and the go/format API that implement standard
formatting of Go source code, so there isn't a need to expose StdFormat
flag to the world, as it can only cause confusion.

Consider that to format source in canonical gofmt style completely it
may require tasks A, B, C to be done. In one version of Go, the printer
may do both A and B, while cmd/gofmt and go/format will do the remaining
task C. In another version, the printer may take on doing just A, while
cmd/gofmt and go/format will perform B and C. This makes it hard to add
a gofmt-like mode to the printer without compromising on above fluidity.

This change prefers to shift back some complexity to the implementation
of the standard library, allowing us to avoid creating the new exported
printing flag just for the internal needs of gofmt and go/format today.

We may still want to re-think the API and consider if something better
should be added, but unfortunately there isn't time for Go 1.15. We are
not adding new APIs now, so we can defer this decision until Go 1.16 or
later, when there is more time.

For #37476.
For #37453.
For #39489.
For #37419.

Change-Id: I0bb07156dca852b043487099dcf05c5350b29e20
Reviewed-on: https://go-review.googlesource.com/c/go/+/240683
Reviewed-by: Robert Griesemer <gri@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/243221 mentions this issue: doc/go1.15: surface the crypto/x509 Common Name deprecation note

gopherbot pushed a commit that referenced this issue Jul 17, 2020
@bmkessler @griesemer
doc/go1.15: add release notes for math/cmplx
0951939 
Updates #37419

Change-Id: Id7c9aba518c826c1a6fccbbf82210072bd3346f3
Reviewed-on: https://go-review.googlesource.com/c/go/+/242903
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
gopherbot pushed a commit that referenced this issue Jul 23, 2020
@aclements
doc/go1.15: announce GO386=387 deprecation
78c20c8 
For #40255.
Updates #37419.

Change-Id: If9210c855cc2eea079e7e469463d4203888748f7
Reviewed-on: https://go-review.googlesource.com/c/go/+/243137
Reviewed-by: Andrew Bonventre <andybons@golang.org>
gopherbot pushed a commit that referenced this issue Jul 24, 2020
@FiloSottile
doc/go1.15: surface the crypto/x509 CommonName deprecation note
074f2d8 
Updates #39568
Updates #37419
Updates #24151

Change-Id: I44c940e09e26a039076396bbfecb2b1574197cf7
Reviewed-on: https://go-review.googlesource.com/c/go/+/243221
Reviewed-by: Kevin Burke <kev@inburke.com>
@c-yan
Copy link

c-yan commented Jul 26, 2020

The section titled "New warning for impossible interface conversions" is titled "impossible interface conversions", but all the text says "assertions" instead of "conversions".

I feel the title should be rewritten with "assertions" as well, but what do you think?

@c-yan
Copy link

c-yan commented Jul 26, 2020

I feel that "The goroutine profile includes the profile labels associated with each goroutine at the time of profiling" would be better with "now" before "includes" as in the other text, but what do you think?

@ainar-g
Copy link
Contributor

ainar-g commented Jul 27, 2020

RC1 is already out, but the release notes still have the “DRAFT” notice. Should I send a CL to remove that?

@dmitshur
Copy link
Contributor Author

The draft notice is correct. We generally remove it as part of making the final release, not earlier.

@andybons andybons added the recurring Issues that should never be closed, but moved to the next milestone once fixed in the current one. label Jul 30, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/245977 mentions this issue: doc/go1.15: add code tag

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/245978 mentions this issue: doc/go1.15: add "now"

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/245979 mentions this issue: doc/go1.15: add dd's closing tag

gopherbot pushed a commit that referenced this issue Aug 1, 2020
@toshihiro-shiino @dmitshur
doc/go1.15: fix a few trivial inconsistencies
10523c0 
For #37419

Change-Id: I8ede539df5d5344aeb44ba1a7e2383363d92157f
Reviewed-on: https://go-review.googlesource.com/c/go/+/245977
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@andybons andybons mentioned this issue Aug 10, 2020
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/247718 mentions this issue: doc/go1.15: encoding/json's CL 191783 was reverted

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/247772 mentions this issue: doc/go1.15: remove draft notice

gopherbot pushed a commit that referenced this issue Aug 10, 2020
@andybons
doc/go1.15: remove draft notice
5ff5b3c 
Updates #37419

Change-Id: I945fd1f8d87b15cf3143808dc68021b38531297d
Reviewed-on: https://go-review.googlesource.com/c/go/+/247772
Run-TryBot: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
gopherbot pushed a commit that referenced this issue Aug 10, 2020
@mvdan @andybons
doc/go1.15: encoding/json's CL 191783 was reverted
5c7748d 
See golang.org/cl/240657, which reverted the original change to fix the
regression reported in golang.org/issue/39427.

Updates #37419.

Change-Id: I39fbaa0b028ee00856cffea38879a631f540f057
Reviewed-on: https://go-review.googlesource.com/c/go/+/247718
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@andybons andybons modified the milestones: Go1.15, Go1.16 Aug 11, 2020
@dmitshur dmitshur mentioned this issue Aug 11, 2020
Closed
@dmitshur
Copy link
Contributor Author

Release notes for each major Go release are quite distinct, let's keep using separate tracking issues for tracking all the incoming changes. Closing this issue as done for Go 1.15 (and moving back to Go1.15 milestone).

Made #40700 as the tracking issue for Go 1.16 release notes.

@dmitshur dmitshur modified the milestones: Go1.16, Go1.15 Aug 11, 2020
@dmitshur dmitshur mentioned this issue Feb 22, 2021
Closed
@golang golang locked and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. recurring Issues that should never be closed, but moved to the next milestone once fixed in the current one. release-blocker
Projects
None yet
Milestone
Go1.15
Development

No branches or pull requests
6 participants
@toothrot @c-yan @andybons @dmitshur @ainar-g @gopherbot