Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: update /doc/install/source page after GO386 changes #41861

Closed
ALTree opened this issue Oct 8, 2020 · 6 comments
Closed

x/website: update /doc/install/source page after GO386 changes #41861

ALTree opened this issue Oct 8, 2020 · 6 comments
Labels
Documentation Issues describing a change to documentation. early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.17

Comments

@ALTree
Copy link
Member

ALTree commented Oct 8, 2020 •
edited
Loading

The Installing Go from source page says (in the section dedicated to Env Variables):

$GO386 (for 386 only, default is auto-detected if built on either 386 or amd64, 387 otherwise)

This controls the code generated by gc to use either the 387 floating-point unit (set to 387) or SSE2 instructions (set to sse2) for floating point computations.

  • GO386=387: use x87 for floating point operations; should support all x86 chips (Pentium MMX or later).
  • GO386=sse2: use SSE2 for floating point operations; has better performance than 387, but only available on Pentium 4/Opteron/Athlon 64 or later.

The section should be updated to reflect the planned 1.16 deprecation of 387, and the softfloat support.

cc @dmitshur
@ALTree ALTree added the Documentation Issues describing a change to documentation. label Oct 8, 2020
@gopherbot gopherbot added this to the Unreleased milestone Oct 8, 2020
@ALTree ALTree added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 8, 2020
@ALTree ALTree modified the milestones: Unreleased, Go1.16 Oct 8, 2020
@ALTree ALTree changed the title x/website: update install from source page after GO386 changes doc: update install from source page after GO386 changes Oct 8, 2020
@dmitshur
Copy link
Contributor

dmitshur commented Oct 8, 2020 •
edited
Loading

Thanks for spotting this @ALTree.

@randall77 Would you like to send a CL for this? The file that needs to be updated is in x/website, here. (There's also an old copy of it in the main repo, but that needs to be deleted; I re-opened #40496 (comment) for that.)

Edit: Since the file is in x/website, we should not submit the CL until Go 1.16 comes out. Can add wait-release hashtag to it.

@dmitshur dmitshur changed the title doc: update install from source page after GO386 changes x/website: update /doc/install/source page after GO386 changes Oct 8, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/260757 mentions this issue: doc: update install docs for 387->softfloat transition

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/260700 mentions this issue: content/static/doc: update install docs for 387->softfloat transition

gopherbot pushed a commit to golang/website that referenced this issue Oct 12, 2020
@randall77
content/static/doc: update install docs for 387->softfloat transition
fa50201 
Fixes golang/go#41861

Change-Id: Ib24851e4423d63cc7baa7bee176798f6eb35364d
Reviewed-on: https://go-review.googlesource.com/c/website/+/260700
Trust: Keith Randall <khr@golang.org>
Trust: Alberto Donizetti <alb.donizetti@gmail.com>
Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com>
@dmitshur
Copy link
Contributor

Reopening because the x/website CL was reverted in CL 261557. x/website needs to be modified when Go 1.16 is released. I'll move this to Go 1.17 milestone with early-in-cycle.

@dmitshur dmitshur reopened this Oct 14, 2020
@dmitshur dmitshur added the early-in-cycle A change that should be done early in the 3 month dev cycle. label Oct 14, 2020
@dmitshur dmitshur modified the milestones: Go1.16, Go1.17 Oct 14, 2020
@dmitshur dmitshur mentioned this issue Dec 13, 2020
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/291692 mentions this issue: content/doc: update install-source.html with changes from main repo

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/291709 mentions this issue: doc: remove install.html and install-source.html

gopherbot pushed a commit that referenced this issue Feb 16, 2021
@rsc
doc: remove install.html and install-source.html
626ef08 
These live in x/website/content/doc now.
The copies here just attract edits that have no actual effect.

For #40496.
For #41861.

Change-Id: I2fdd7375e373949eb9a88f4cdca440b6a5d45eea
Reviewed-on: https://go-review.googlesource.com/c/go/+/291709
Trust: Russ Cox <rsc@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@golang golang locked and limited conversation to collaborators Feb 16, 2022
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
content/static/doc: update install docs for 387->softfloat transition
9570d77 
Fixes golang/go#41861

Change-Id: Ib24851e4423d63cc7baa7bee176798f6eb35364d
Reviewed-on: https://go-review.googlesource.com/c/website/+/260700
Trust: Keith Randall <khr@golang.org>
Trust: Alberto Donizetti <alb.donizetti@gmail.com>
Reviewed-by: Alberto Donizetti <alb.donizetti@gmail.com>
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
_content/doc: update install-source.html with changes from main repo
7879f09 
Copied from Go ff0e93ea3, deleted there in CL 291709.

Fixes golang/go#40496.
Fixes golang/go#41861.

Change-Id: Idb04706ea46b97be69fbeb98637c7ac2e4b54729
Reviewed-on: https://go-review.googlesource.com/c/website/+/291692
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
4 participants
@dmitshur @ALTree @bcmills @gopherbot