-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: empty title for go mod tidy
suggested fix
#43234
Comments
Do you see any diagnostics on the files in your workspace, likely on a |
Hi @stamblerre Yes, looks like there is a diag line in there. The fix seems a bit busted though, it's two empty entries. I'm a little wary of clicking on them. 😅 I guess I could run "go mod tidy" manually. It seems a little unfortunate though, from a workflow perspective. Is this expected to be the normal workflow for vscode-go going forward with gopls >= 0.60? Thank you! |
I'm not sure I understand this--what empty entries are you referring to? All that fix will do is run And yes, the |
@stamblerre Notice the menu dropdown. I'm assuming there are two fixes listed there, but they are both blank, i.e. they don't describe what they do, their name, or anything. So I'm being asked to click on a menu item which is blank. I suspect there's supposed to be some text there. |
Oh I didn't realize that was a drop-down menu. Thank you for pointing that out--I will transfer this to the |
go mod tidy
suggested fix
Sounds good. Thanks for letting me know about the expected workflow going forward! |
Change https://golang.org/cl/278778 mentions this issue: |
Change https://golang.org/cl/278785 mentions this issue: |
…and update go.sum fixes These were missing titles, which was showing up empty for users in the VS Code UI and leading people not to trust the fixes. Also did a find references on SuggestedFix to confirm that we always set the title in other cases. Fixes golang/go#43234 Change-Id: I8d0f272c383a2e1a364aefcec6650988d18d4fb4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/278778 Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> (cherry picked from commit 48e5bd1) Reviewed-on: https://go-review.googlesource.com/c/tools/+/278785
0.6.1 This is a patch release to fix golang/go#43234. The titles of some suggested fixes were blank, leading to a bad user experience. 0.6.0 Features - Default to -mod=readonly - Default to GOPROXY=off - Inclusion/exclusion filters for directories - Debouncing for diagnostics - "Upgrade direct dependencies" code lens - Support for filling a partially-populated struct - Experimental: Field alignment analyzer Fixes - Improvements to diagnostics tracking - File watching for directories Other - "codelens" setting name changed to "codelenses" - Disabled support for symlinks
These were missing titles, which was showing up empty for users in the VS Code UI and leading people not to trust the fixes. Also did a find references on SuggestedFix to confirm that we always set the title in other cases. Fixes golang/go#43234 Change-Id: I8d0f272c383a2e1a364aefcec6650988d18d4fb4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/278778 Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
What version of Go, VS Code & VS Code Go extension are you using?
go version: go1.14.9 linux/amd64
gopls version: golang.org/x/tools/gopls v0.6.0
vscode version: 1.52.1 (commit ea3859d4ba2f3e577a159bc91e3074c5d85c0523)
vscode-go version: 0.19.1
Share the Go related settings you have added/edited
Describe the bug
VSCode is running on macOS, vscode-go is running on linux/amd64 (I'm using the remote-ssh extension).
I just upgraded to gopls 0.60. Now vscode is yelling at me about the workspace needing go.mod changes, presumably due to the
-mod=readonly
change introduced to gopls 0.60. The status bar reads "Error loading workspace", and has a permanent spinner.I'm not aware of anything I can do configuration-wise to solve this problem, so I think this might count as a bug. Not entirely sure.
Any help would be appreciated. Thank you.
The text was updated successfully, but these errors were encountered: