Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/curve25519/internal/field/_asm: running go generate panics #46133

Closed
tklauser opened this issue May 12, 2021 · 1 comment · May be fixed by rosetta-dogecoin/rosetta-dogecoin#57
Closed

x/crypto/curve25519/internal/field/_asm: running go generate panics #46133

tklauser opened this issue May 12, 2021 · 1 comment · May be fixed by rosetta-dogecoin/rosetta-dogecoin#57
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@tklauser
Copy link
Member

For https://golang.org/cl/319469 I wanted to run go generate in x/crypto/curve25519/internal/field/_asm, which lead to the following panic:

$ go generate
panic: unknown variable "b"

goroutine 1 [running]:
main.mustAddr(...)
	/home/tklauser/go/src/golang.org/x/crypto/curve25519/internal/field/_asm/fe_amd64_asm.go:291
main.mul64(0x6c2681, 0x2, 0x718828, 0xc00009f060, 0x718828, 0xc00009f070, 0x1, 0x717d98, 0xc00009ef70, 0x6c2645, ...)
	/home/tklauser/go/src/golang.org/x/crypto/curve25519/internal/field/_asm/fe_amd64_asm.go:248 +0x9fc
main.feMul()
	/home/tklauser/go/src/golang.org/x/crypto/curve25519/internal/field/_asm/fe_amd64_asm.go:150 +0x874
main.main()
	/home/tklauser/go/src/golang.org/x/crypto/curve25519/internal/field/_asm/fe_amd64_asm.go:21 +0x70
exit status 2
fe_amd64_asm.go:16: running "go": exit status 1

The panic also occurs without the changes in https://golang.org/cl/319469

/cc @FiloSottile
@tklauser tklauser added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 12, 2021
@gopherbot gopherbot added this to the Unreleased milestone May 12, 2021
@FiloSottile FiloSottile self-assigned this May 12, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/319471 mentions this issue: curve25519/internal/field: fix generator module reference to x/crypto

@xanimo xanimo mentioned this issue May 30, 2021
Draft
@golang golang locked and limited conversation to collaborators May 13, 2022
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this issue Feb 16, 2023
@FiloSottile
curve25519/internal/field: fix generator module reference to x/crypto
2476f34 
The generator submodule needs a module dependency on golang.org/x/crypto
to find the type information it needs.

This removes the Comment call from CL 319469 because it does not seem to
generate the intended output. See golang/go#46155.

Fixes golang/go#46133

Change-Id: Iec21c6379d81271047ebf370a76329ed3fdac85c
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/319471
Trust: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
@FiloSottile
curve25519/internal/field: fix generator module reference to x/crypto
ef1721a 
The generator submodule needs a module dependency on golang.org/x/crypto
to find the type information it needs.

This removes the Comment call from CL 319469 because it does not seem to
generate the intended output. See golang/go#46155.

Fixes golang/go#46133

Change-Id: Iec21c6379d81271047ebf370a76329ed3fdac85c
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/319471
Trust: Filippo Valsorda <filippo@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

upgrade deps xanimo/rosetta-dogecoin
3 participants
@tklauser @FiloSottile @gopherbot