Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/env/openbsd-{386,amd64}: add an OpenBSD 7.0 (or newer) builder #48977

Closed
toothrot opened this issue Oct 14, 2021 · 10 comments
Closed

x/build/env/openbsd-{386,amd64}: add an OpenBSD 7.0 (or newer) builder #48977

toothrot opened this issue Oct 14, 2021 · 10 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. new-builder OS-OpenBSD
Milestone
Unreleased

Comments

@toothrot
Copy link
Contributor

OpenBSD 7.0 has been released. We should probably update the 6.4 builder to 7.0, and keep the 6.8 one around.
@toothrot toothrot added the Builders x/build issues (builders, bots, dashboards) label Oct 14, 2021
@toothrot toothrot added this to the Unreleased milestone Oct 14, 2021
@toothrot toothrot added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 15, 2021
@bcmills
Copy link
Contributor

bcmills commented Oct 19, 2021

Should we have recurring issues filed for builders with known support windows? It looks like the OpenBSD releases occur pretty reliably by October and May each year, so in theory the OpenBSD builder upgrades should happen at a predictable point in each Go development cycle.

@dmitshur dmitshur changed the title x/build/env/openbsd-{386,amd64}: upgrade to 7.0 builder x/build/env/openbsd-{386,amd64}: add an OpenBSD 7.0 (or newer) builder Oct 20, 2021
@dmitshur dmitshur mentioned this issue Oct 20, 2021
Closed
@4a6f656c
Copy link
Contributor

For the record, the only two supported OpenBSD releases are currently 6.9 and 7.0 (6.8 is no longer a supported release).

@4a6f656c
Copy link
Contributor

Should we have recurring issues filed for builders with known support windows? It looks like the OpenBSD releases occur pretty reliably by October and May each year, so in theory the OpenBSD builder upgrades should happen at a predictable point in each Go development cycle.

This is correct - OpenBSD is released on a 6 month interval, the 7.1 release will be around May 2022 and the 7.2 release will be around October 2022.

@dmitshur dmitshur mentioned this issue Oct 27, 2021
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/360694 mentions this issue: unix: regenerate type Clockinfo on OpenBSD 6.9

gopherbot pushed a commit to golang/sys that referenced this issue Nov 3, 2021
@tklauser
unix: regenerate type Clockinfo on OpenBSD 6.9
ae416a5 
OpenBSD 6.9 changed the definition of Clockinfo, leading
TestSysctlClockinfo to fail on OpenBSD 6.9 onwards. Since OpenBSD 6.8 is
no longer supported upstream, regenerate Clockinfo on that release and
test that SysctlClockInfo fails gracefully on OpenBSD 6.8 and earlier.

Fixes golang/go#47629
For golang/go#48977

Change-Id: Ia511b8601af11f70ffcce0f96764c69a67d626b8
Reviewed-on: https://go-review.googlesource.com/c/sys/+/360694
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Joel Sing <joel@sing.id.au>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/364094 mentions this issue: env,dashboard: add OpenBSD 7.0

gopherbot pushed a commit to golang/build that referenced this issue Nov 16, 2021
@heschi
env,dashboard: add OpenBSD 7.0
90a1d27 
all.bash takes a long time on these builders. I'll keep an eye on them
to see if it causes trouble.

For golang/go#48977.

Change-Id: I0239a93c004157855968dab397e68abe38f5f439
Reviewed-on: https://go-review.googlesource.com/c/build/+/364094
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@bcmills
Copy link
Contributor

bcmills commented Nov 17, 2021

The new openbsd-386-70 builder is segfaulting on every subrepo on the 1.16 release branch, and on many of the subrepos for 1.17. Should we restrict it to only 1.18 and later, or do we expect someone to backport fixes for those releases?

@bcmills
Copy link
Contributor

bcmills commented Nov 17, 2021

(The builder is also failing on x/net everywhere due to #42064; updated that issue with details.)

@heschi
Copy link
Contributor

heschi commented Nov 17, 2021

We should clearly turn it off for 1.16. FWIW, 1.17 looks no flakier than tip to me? Am I missing something?

@bcmills
Copy link
Contributor

bcmills commented Nov 17, 2021 •
edited
Loading

It's not clear to me whether 1.17 is worse than tip, but there are certainly more fail cells at the head commit for the subrepos:
image

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/365777 mentions this issue: buildlet,dashboard: tweaks to Darwin, OpenBSD, and Linux builders

gopherbot pushed a commit to golang/build that referenced this issue Nov 19, 2021
@heschi
buildlet,dashboard: tweaks to Darwin, OpenBSD, and Linux builders
3ffd700 
- Add more Monterey builders and remove the known issue: it's stable.
  Also use it for race and nocgo. Update slowbot aliases to point to it.
- Don't test 1.16 on OpenBSD 7.0, it segfaults.
- Pin the Linux (ContainerOS) builders to an older version to avoid the
  pprof kernel bug.

For golang/go#49065, golang/go#49149, and golang/go#48977.

Change-Id: Ibec2fa735183ec65e5066c7c752ac356b7360550
Reviewed-on: https://go-review.googlesource.com/c/build/+/365777
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@rsc rsc unassigned heschi Jun 23, 2022
@heschi heschi moved this to Done in Go Release Sep 27, 2022
@bcmills bcmills mentioned this issue Nov 17, 2022
Closed
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. new-builder OS-OpenBSD
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@toothrot @dmitshur @bcmills @4a6f656c @gopherbot @heschi