Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/windows/registry: TestReadSubKeyNames failures with "Access is denied" #49466

Closed
bcmills opened this issue Nov 8, 2021 · 4 comments
Closed

x/sys/windows/registry: TestReadSubKeyNames failures with "Access is denied" #49466

bcmills opened this issue Nov 8, 2021 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows release-blocker
Milestone
Go1.18

Comments

@bcmills
Copy link
Contributor

bcmills commented Nov 8, 2021

greplogs --dashboard -md -l -e 'FAIL: TestReadSubKeyNames'

2021-11-08T18:54:21-e0b2ad0-830b393/windows-386-2008
2021-11-05T19:48:29-c75c477-c353f1b/windows-386-2008
2021-11-05T19:14:22-c75c477-fa16efb/windows-amd64-2016
2021-11-05T18:20:07-7861aae-53bab19/windows-386-2008
2021-11-05T17:52:30-7861aae-df18377/windows-amd64-2016
2021-11-05T16:54:01-7861aae-3796df1/windows-386-2008
2021-11-05T15:52:40-7861aae-a0d661a/windows-386-2008
2021-11-04T20:43:07-7861aae-8248152/windows-386-2008
2021-11-04T20:31:02-7861aae-978e39e/windows-386-2008
2021-11-04T20:01:22-7861aae-6d1fffa/windows-386-2008

I seem to recall @mknyszek fixing a similar bug in the main repo — possibly #49320?

(CC @alexbrainman @bufflig)
@bcmills bcmills added OS-Windows NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Nov 8, 2021
@bcmills bcmills added this to the Go1.18 milestone Nov 8, 2021
@mknyszek
Copy link
Contributor

mknyszek commented Nov 8, 2021

Yeah, this looks the same. The fix is, basically, runtime.LockOSThread in the relevant method.

@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 9, 2021
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 9, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/362576 mentions this issue: windows/registry: lock OS thread while enumerating keys

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/362577 mentions this issue: all: add missing //go:build comments

gopherbot pushed a commit to golang/sys that referenced this issue Nov 10, 2021
all: add missing //go:build comments
99a5385 
These were apparently overlooked in CL 357329, CL 294490, CL 296889,
and other various updates to this module. (I noticed them via gopls
while investigating golang/go#49466.)

Updates golang/go#41184

Change-Id: Id042bb6fe5282e6d528e9315acf2ad29d0df58ba
Reviewed-on: https://go-review.googlesource.com/c/sys/+/362577
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
@bcmills
Copy link
Contributor Author

bcmills commented Dec 8, 2021

Confirmed that the above CLs seem to have resolved this failure mode:

greplogs --dashboard -md -l -e 'FAIL: TestReadSubKeyNames' --since=2021-11-10

@bcmills bcmills mentioned this issue Dec 8, 2021
Closed
@golang golang locked and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
3 participants
@mknyszek @bcmills @gopherbot