-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime/race: upstream OpenBSD support is removed #52090
Comments
Change https://go.dev/cl/397494 mentions this issue: |
Why was it even dropped? It is not very clear from the issue above. |
I added the initial bits for llvm. No clue why they added it - I will ask. My pref is to keep it enabled in Go if at all possible. I use the feature pretty regularly. |
For now we can just not update TSAN on openbsd. The updates we want to do are mostly performance, so it is ok if it isn't available everywhere (the 8192 goroutine limit might be annoying if it is gone everywhere else, though). Longer term that isn't a solution, though. At some point we'd have to either fix openbsd support or drop the openbsd race detector. |
Honestly, I don't know what happened. But it was removed from everywhere, not just tsan. |
Following CL 333529, update syso files for other architectures. Windows/AMD64 is not updated, waiting for Than for C toolchain updates. OpenBSD/AMD64 is not updated as upstream LLVM TSAN removed OpenBSD support (#52090). Linux/PPC64LE is not updated due to a test failure. Will look into it. Change-Id: I46441fd3bb0f2c9e372d3e7fd43744ffafaf87a1 Reviewed-on: https://go-review.googlesource.com/c/go/+/397494 Trust: Cherry Mui <cherryyz@google.com> Reviewed-by: Keith Randall <khr@golang.org>
I don't think there is anything we can do here, other than carry forward the old OpenBSD race support, so closing this issue. |
LLVM TSAN removed OpenBSD support ( https://reviews.llvm.org/rG53065c543fe3f1e7913c9e8f2487d76034afa249 )
What do we do for the race detector on OpenBSD? Do we want to remove it, or try to add it back to LLVM?
cc @dvyukov @4a6f656c @golang/runtime
The text was updated successfully, but these errors were encountered: