-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: autocomplete returns packages within excluded directories (per build.directoryFilters) #52347
Comments
I came across a related issue: #42965 From browsing the source, I wonder if the call to imports.GetAllCandidates from completions.go could be altered to pass in a filter derived from the |
This bug may also be a duplicate of #51265, not totally sure. |
Attempted fix for golang/go#52347.
I just implemented something similar to this in https://go.dev/cl/531417. Notes on how to implement this:
May not get to this for v0.14, which we want to cut ASAP to include a completion performance fix. |
Would this completely stop gopls from scanning excluded sub directories? |
Related to #48939 and reproduced in a repository.
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes:
~/git/go-tools$ git log -n 1 commit fe932b4680bd8878524bfea7a12f7cf30e1e0438
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
myl
within a function. The autocomplete list will include a library in thegenerated_stuff
dir, which is included in thebuild.directoryFilters
exclusion list:What did you expect to see?
Packages in generated_stuff shouldn't be included in autocomplete list?
I can't tell if this is working as intended. It came up before in #37697, but I interpret the build.directoryFilters to mean that the generated_stuff folder should be ignored in this context as well: https://github.com/golang/vscode-go/blob/master/docs/settings.md#builddirectoryfilters.
What did you see instead?
mylib
is included in the autocomplete list.The text was updated successfully, but these errors were encountered: